Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fixing invalid finalization from non-primary ES #281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdorier
Copy link
Contributor

@mdorier mdorier commented Aug 1, 2024

This branch/PR aims to fix the problem that appears when multiple ES use the pool from which margo_cleanup is called. This causes the ES that executes it to self-destruct, cutting short the finalization of margo.

I added a test (finalize_from_non_primary in margo-init unit test) showcasing the problem.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.65%. Comparing base (3a7a8e0) to head (c705b76).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   57.58%   57.65%   +0.06%     
==========================================
  Files          70       70              
  Lines        9877     9885       +8     
  Branches     1271     1271              
==========================================
+ Hits         5688     5699      +11     
+ Misses       3406     3402       -4     
- Partials      783      784       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant