Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print warnings if configurations could lead to deadlocks or starvation scenarios #279

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

mdorier
Copy link
Contributor

@mdorier mdorier commented Jul 31, 2024

This PR adds warnings if the configuration is such that some pools could be starved.

@mdorier mdorier requested a review from carns July 31, 2024 12:46
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 85.21739% with 17 lines in your changes missing coverage. Please review.

Project coverage is 57.54%. Comparing base (4cdf588) to head (6f8982b).

Files Patch % Lines
src/margo-init.c 64.58% 2 Missing and 15 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   57.21%   57.54%   +0.32%     
==========================================
  Files          69       70       +1     
  Lines        9740     9855     +115     
  Branches     1256     1271      +15     
==========================================
+ Hits         5573     5671      +98     
- Misses       3399     3401       +2     
- Partials      768      783      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@carns carns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@mdorier mdorier merged commit 58d137a into main Aug 1, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants