Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernisation - latest dependencies, re-indent JS, replace mobx decorators with non-decorator equivalents #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pdorrell
Copy link

@pdorrell pdorrell commented Oct 9, 2021

Hi, I'm new to "modern" Javascript development & react & mobx, so I picked this project as an example to figure out how to set up my IDE (emacs).

It turns out the project is a bit out-of-date (I guess 3 years is a long time in Javascript land).

My pull request contains the following changes:

  • Update to latest dependencies, replacing or removing deprecated dependencies
  • Turn on source maps for development
  • Re-indent Javascript code to 2 spaces per indent level (that's what I normally use, and that's what it says at https://standardjs.com/rules.html - is that OK?)
  • Replace mobx decorators with non-decorator equivalents
  • Fix warnings about filter values being updated outside of an action

There aren't any automated tests, but I have tested it manually: adding, completing, deleting & filtering todos.

Yours, Philip.

@pdorrell pdorrell changed the title Modernisation - latest dependencies, re-indent JS, replace mobx observables Modernisation - latest dependencies, re-indent JS, replace mobx decorators with non-decorator equivalents Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant