Fix Firebase Realtime database Boolean issue.

mobizt · Apr 10, 2024 · 2aae95a · 2aae95a
1 parent 6cd3f65
commit 2aae95a
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 13 deletions.
diff --git a/library.json b/library.json
@@ -1,6 +1,6 @@
 {
   "name": "FirebaseClient",
-  "version": "1.0.14",
+  "version": "1.0.15",
   "keywords": "communication, REST, esp32, esp8266, arduino",
   "description": "Async Firebase Client library for Arduino.",
   "repository": {

diff --git a/library.properties b/library.properties
@@ -1,6 +1,6 @@
 name=FirebaseClient
 
-version=1.0.14
+version=1.0.15
 
 author=Mobizt
 

diff --git a/src/FirebaseClient.h b/src/FirebaseClient.h
@@ -30,7 +30,7 @@
 #undef FIREBASE_CLIENT_VERSION
 #endif
 
-#define FIREBASE_CLIENT_VERSION "1.0.14"
+#define FIREBASE_CLIENT_VERSION "1.0.15"
 
 #include <Arduino.h>
 #include "./core/FirebaseApp.h"

diff --git a/src/core/AsyncResult/Value.h b/src/core/AsyncResult/Value.h
@@ -1,5 +1,5 @@
 /**
- * Created April 7, 2024
+ * Created April 10, 2024
  *
  * The MIT License (MIT)
  * Copyright (c) 2024 K. Suwatchai (Mobizt)
@@ -200,7 +200,7 @@ class ValueConverter
     {
         static bool const value = std::is_same<T, uint64_t>::value || std::is_same<T, int64_t>::value || std::is_same<T, uint32_t>::value || std::is_same<T, int32_t>::value ||
                                   std::is_same<T, uint16_t>::value || std::is_same<T, int16_t>::value || std::is_same<T, uint8_t>::value || std::is_same<T, int8_t>::value ||
-                                  std::is_same<T, double>::value || std::is_same<T, float>::value || std::is_same<T, bool>::value || std::is_same<T, int>::value;
+                                  std::is_same<T, double>::value || std::is_same<T, float>::value || std::is_same<T, int>::value;
     };
 
     template <typename T = object_t>
@@ -210,18 +210,25 @@ class ValueConverter
     }
 
     template <typename T = const char *>
-    auto getVal(String &buf, T value) -> typename std::enable_if<(v_number<T>::value || v_sring<T>::value) && !std::is_same<T, object_t>::value && !std::is_same<T, string_t>::value && !std::is_same<T, boolean_t>::value && !std::is_same<T, number_t>::value, void>::type
+    auto getVal(String &buf, T value) -> typename std::enable_if<(v_number<T>::value || v_sring<T>::value || std::is_same<T, bool>::value) && !std::is_same<T, object_t>::value && !std::is_same<T, string_t>::value && !std::is_same<T, boolean_t>::value && !std::is_same<T, number_t>::value, void>::type
     {
-        buf = "";
-        if (v_sring<T>::value)
-            buf += '\"';
-        buf += value;
-        if (v_sring<T>::value)
-            buf += '\"';
+        buf.remove(0, buf.length());
+        if (std::is_same<T, bool>::value)
+        {
+            buf = value ? "true" : "false";
+        }
+        else
+        {
+            if (v_sring<T>::value)
+                buf += '\"';
+            buf += value;
+            if (v_sring<T>::value)
+                buf += '\"';
+        }
     }
 
     template <typename T>
-    auto to(const char *payload) -> typename std::enable_if<v_number<T>::value, T>::type
+    auto to(const char *payload) -> typename std::enable_if<v_number<T>::value || std::is_same<T, bool>::value, T>::type
     {
         if (!useLength && strlen(payload) > 0)
         {