Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path names in dataset.json generated in Windows contain \ #132

Closed
martinschorb opened this issue Feb 19, 2024 · 4 comments
Closed

path names in dataset.json generated in Windows contain \ #132

martinschorb opened this issue Feb 19, 2024 · 4 comments

Comments

@martinschorb
Copy link
Contributor

Hi,

I have run a conversion using mobie_utils on Windows. The resulting dataset.json contains

        "imageData": {
          "ome.zarr": {
            "relativePath": "images\\ome-zarr\\FLM_a1_R.ome.zarr"
          }

which makes the viewer crash.

I remember vaguely that there was a fix at some point.
Any ideas why it is wrong again?

@martinschorb
Copy link
Contributor Author

To be more precise. The viewer works when run on Windows.

found something here..
#78

@constantinpape would it make sense to change the code for generating the source metadata in using / no matter the platform you run it on?

I can look into that if you like.

@martinschorb
Copy link
Contributor Author

martinschorb commented Feb 19, 2024

I would basically modify

if file_format.startswith("bdv"):
to write forward slashes and check the validation and tests that this implies.

Any objections?

I think it makes sense to enable creating cross-platform MoBIE projects also from Windows.

@constantinpape
Copy link
Contributor

Hi @martinschorb ,
yes that makes sense, no objections from my side.

@constantinpape
Copy link
Contributor

Fixed by #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants