Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and updates #96

Merged
merged 4 commits into from
May 18, 2022
Merged

Fixes and updates #96

merged 4 commits into from
May 18, 2022

Conversation

KateMoreva
Copy link
Collaborator

- try to fix bug with bdv.ome.zarr
- doesObjectExist removed in N5S3OMEZarrReader
Copy link
Collaborator

@tischi tischi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few comments.
Otherwise looks good.
Thanks!

@KateMoreva KateMoreva requested a review from tischi May 18, 2022 08:51
Copy link
Collaborator

@tischi tischi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found sub-optimal variable names at some other places.

@KateMoreva
Copy link
Collaborator Author

I found sub-optimal variable names at some other places.

Fixed.

@tischi tischi merged commit dd54eab into develop May 18, 2022
@tischi tischi deleted the publiation_fixes branch May 18, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants