-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and updates #96
Conversation
- try to fix bug with bdv.ome.zarr - doesObjectExist removed in N5S3OMEZarrReader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few comments.
Otherwise looks good.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found sub-optimal variable names at some other places.
src/main/java/org/embl/mobie/io/ome/zarr/readers/N5S3OmeZarrReader.java
Outdated
Show resolved
Hide resolved
src/main/java/org/embl/mobie/io/ome/zarr/readers/N5S3OmeZarrReader.java
Outdated
Show resolved
Hide resolved
Fixed. |
bdv v 10.2.2
MoBIE-io incompatible with bigdataviewer-core:10.2.2 #94
doesObjectExist removed in N5S3OMEZarrReader
Remove doesObjectExist() calls everywhere? #91
tried to fix bug with bdv.ome.zarr