Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoBIE-io incompatible with bigdataviewer-core:10.2.2 #94

Open
K-Meech opened this issue May 6, 2022 · 3 comments
Open

MoBIE-io incompatible with bigdataviewer-core:10.2.2 #94

K-Meech opened this issue May 6, 2022 · 3 comments

Comments

@K-Meech
Copy link
Contributor

K-Meech commented May 6, 2022

The newest version of fiji ships with bigdataviewer-core:10.2.2 which is currently incompatible with mobie-io. Trying to build with this version errors with:
java: org.embl.mobie.io.n5.loaders.N5ImageLoader.N5CacheArrayLoader is not abstract and does not override abstract method loadArray(long[],int[]) in bdv.img.cache.SimpleCacheArrayLoader

This isn't currently an issue for MoBIE (as I think we have bigdataviewer-core:10.2.1 on the MoBIE update site?), but it causes issues in other plugins that only depend on mobie/mobie-io (like some of mine for the Schwab lab :)

@tischi - do you think we could change mobie/mobie-io to the new bigdataviewer-core version? Also, was there a particular reason to put this on the MoBIE update sites, rather than relying on the one that comes with fiji?

@tischi
Copy link
Collaborator

tischi commented May 6, 2022

Do you think we could change mobie/mobie-io to the new bigdataviewer-core version?

Yes! We should definitely do this! @KateMoreva could you please look into the above error and update the bdv-core dependency in the pom?

Also, was there a particular reason to put this on the MoBIE update sites, rather than relying on the one that comes with fiji?

For some time we needed a more recent version than the one that shipped with Fiji.
We should then also update the bdv-core dependency in the pom of mobie-viewer-fiji.

Ideal would be to completely remove the version of bdv-core and rely on the scijava-parent-pom, but unf. this is not necessarily what is shipped with Fiji, because of the Java8 update site :-(

@K-Meech
Copy link
Contributor Author

K-Meech commented May 6, 2022

Ok - sounds good! I saw fiji seems to be using a new version of the pom-scijava too (32.0.0-beta-4) - so probably worth updating the pom-scijava version in both too. Although the 'beta' in the name is a bit weird.

@tischi
Copy link
Collaborator

tischi commented May 9, 2022

32.0.0-beta-4

You could ask about that here: https://gitter.im/fiji/fiji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants