change typos, date format, first weekday #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobergmann
reviewed
Nov 18, 2023
| @@ -59,7 +59,7 @@ export async function sign_in(username, password) { | |||
| } | |||
| }) | |||
| .then((response) => { | |||
| console.debug("Sucessfull SignIn"); | |||
| console.debug("Successfull SignIn ajsldkjasd"); | |||
mobergmann
reviewed
Nov 18, 2023
|
|
||
| <article> |
There was a problem hiding this comment.
is article and aside not wanted? I thought semantic html is the way to go/ best practice and makes the life of crawlers easier (and gives a higher score when our website is rated by the search engine).
|
Closed because this PR is a subset of #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Multiple typos changed
*fullyear and weeknumber changed to dd-mm-yyyy format on homescreen
*removed "Home" header since after signup it's the only screen we care about for now
*changed first weekday from sunday to monday