-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added token validation and http only csharp rules. #10
Open
corradot12
wants to merge
1
commit into
mobb-dev:main
Choose a base branch
from
corradot12:csharp-rules-token-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
25 changes: 25 additions & 0 deletions
25
semgrep/csharp/.NET/http_only/csharp_httpOnly_true_for_httpCookie.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
using System.Web; | ||
|
||
// Example of bad usage. | ||
using System.Web; | ||
|
||
class ExampleClass | ||
{ | ||
public void ExampleMethod() | ||
{ | ||
HttpCookie httpCookie = new HttpCookie("cookieName"); | ||
httpCookie.HttpOnly = false; | ||
} | ||
} | ||
|
||
// Solution with the fix applied. | ||
using System.Web; | ||
|
||
class ExampleClass | ||
{ | ||
public void ExampleMethod() | ||
{ | ||
HttpCookie httpCookie = new HttpCookie("cookieName"); | ||
httpCookie.HttpOnly = true; | ||
} | ||
} |
19 changes: 19 additions & 0 deletions
19
semgrep/csharp/.NET/http_only/csharp_httpOnly_true_for_httpCookie.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
rules: | ||
- id: csharp_httpOnly_true_for_httpCookie | ||
languages: | ||
- csharp | ||
message: | | ||
Security threat detected when allowing untrusted tokens to make it through validation. | ||
patterns: | ||
- pattern-inside: | | ||
using System.Web; | ||
... | ||
- pattern-inside: | | ||
HttpCookie $HTTPCOOKIE = new HttpCookie($X); | ||
... | ||
- pattern: | | ||
$HTTPCOOKIE.HttpOnly = false; | ||
fix: $HTTPCOOKIE.HttpOnly = true; | ||
severity: WARNING | ||
metadata: | ||
references: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca5404 |
19 changes: 19 additions & 0 deletions
19
semgrep/csharp/.NET/token_validation/csharp_token_audience_validation_check_enabled.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
rules: | ||
- id: token_audience_validation_check_enabled | ||
languages: | ||
- csharp | ||
message: | | ||
The tokens allowed do not meet the minimum security recommendations! | ||
patterns: | ||
- pattern-inside: | ||
using Microsoft.IdentityModel.Tokens; | ||
... | ||
- pattern-inside: | ||
TokenValidationParameters $PARAMETERS = new TokenValidationParameters(); | ||
... | ||
- pattern: | ||
$PARAMETERS.ValidateAudience = false; | ||
fix: $PARAMETERS.ValidateAudience = true; | ||
severity: WARNING | ||
metadata: | ||
references: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca5404 |
16 changes: 16 additions & 0 deletions
16
semgrep/csharp/.NET/token_validation/csharp_token_issuer_validation_check_enabled.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
rules: | ||
- id: token_issuer_validation_check_enabled | ||
languages: | ||
- csharp | ||
message: | | ||
Insecure token validation. | ||
patterns: | ||
- pattern-inside: | ||
using Microsoft.IdentityModel.Tokens; | ||
... | ||
- pattern-inside: | ||
TokenValidationParameters $PARAMETERS = new TokenValidationParameters(); | ||
... | ||
- pattern: | ||
$PARAMETERS.ValidateIssuer = false; | ||
severity: WARNING | ||
19 changes: 19 additions & 0 deletions
19
semgrep/csharp/.NET/token_validation/csharp_token_lifetime_validation_check_enabled.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
rules: | ||
- id: token_lifetime_validation_check_enabled | ||
languages: | ||
- csharp | ||
message: | | ||
Insecure token validation. | ||
patterns: | ||
- pattern-inside: | ||
using Microsoft.IdentityModel.Tokens; | ||
... | ||
- pattern-inside: | ||
TokenValidationParameters $PARAMETERS = new TokenValidationParameters(); | ||
... | ||
- pattern: | ||
$PARAMETERS.ValidateLifetime = false; | ||
fix: $PARAMETERS.ValidateLifetime = true; | ||
severity: WARNING | ||
metadata: | ||
references: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca5404 |
16 changes: 16 additions & 0 deletions
16
...p/.NET/token_validation/csharp_token_reqire_expiration_time_validation_check_enabled.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
rules: | ||
- id: token_audience_validation_check_enabled | ||
languages: | ||
- csharp | ||
message: | | ||
The tokens allowed do not meet the minimum security recommendations! | ||
patterns: | ||
- pattern-inside: | ||
using Microsoft.IdentityModel.Tokens; | ||
... | ||
- pattern-inside: | ||
TokenValidationParameters $PARAMETERS = new TokenValidationParameters(); | ||
... | ||
- pattern: | ||
$PARAMETERS.RequireExpirationTime = false; | ||
severity: WARNING | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is a fix possible for this rule as well? |
28 changes: 28 additions & 0 deletions
28
semgrep/csharp/.NET/token_validation/csharp_token_validation_checks.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
using System; | ||
using Microsoft.IdentityModel.Tokens; | ||
|
||
// Example of bad usage. | ||
class BadUsageExample | ||
{ | ||
public void ExampleMethod() | ||
{ | ||
TokenValidationParameters parameters = new TokenValidationParameters(); | ||
parameters.RequireExpirationTime = false; | ||
parameters.ValidateAudience = false; | ||
parameters.ValidateIssuer = false; | ||
parameters.ValidateLifetime = false; | ||
} | ||
} | ||
|
||
// Solution with the fix applied. | ||
class SolutionFixForExampleAbove | ||
{ | ||
public void SolutionMethod() | ||
{ | ||
TokenValidationParameters parameters = new TokenValidationParameters(); | ||
parameters.RequireExpirationTime = true; | ||
parameters.ValidateAudience = true; | ||
parameters.ValidateIssuer = true; | ||
parameters.ValidateLifetime = true; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a fix possible for this rule as well?