MAINT: Unpin VTK #12991
Merged
MAINT: Unpin VTK #12991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, we are pinning VTK upstream in PyVista: pyvista/pyvista#6872 |
|
Thanks @banesullivan -- good to know. In the meantime things appear to pass for us with VTK 9.4 at least! In this PR I add some packages back to Windows that didn't used to be on scientific-python-nightly-wheels. Timings on 
Timings on this PR are expectedly worse since fewer tests are skipped: 
I think it's worth it for the increased code coverage on Windows. If we don't like the increased time I could look into cutting it back down with some additional |
drammock
approved these changes
Nov 26, 2024
|
thx @larsoner. Nice to have a bunch of those pins / exclusions gone from the CI config! |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Dec 6, 2024
* upstream/main: (736 commits) ENH: Add round-trip channel name saving (mne-tools#13003) update governance (mne-tools#12896) pin selenium and stop filtering its warning (mne-tools#13000) DOC: fix return value doc of inst.get_montage() (mne-tools#12995) remove some ._filenames uses in favor of .filenames (mne-tools#12996) use eegbci.standardize instead of custom code (mne-tools#12997) Bump autofix-ci/action from dd55f44df8f7cdb7a6bf74c78677eb8acd40cd0a to ff86a557419858bb967097bfc916833f5647fa8c in the actions group (mne-tools#12999) MAINT: Update code credit (mne-tools#12998) MAINT: Unpin VTK (mne-tools#12991) [pre-commit.ci] pre-commit autoupdate (mne-tools#12988) Fix: update cnt.py to check missing annotation (mne-tools#12986) do not log about using set_montage AGAIN if it has never been used (mne-tools#12984) DOC: fix numpy docstr example Vectorizer() (mne-tools#12983) Changed epochs_clean_sub = model_plain.apply(epochs) to epochs_clean_sub = model_sub.apply(epochs), making use of the regression coefficients from model_sub. mne-tools#12977 (mne-tools#12978) DOC: add meegkit to related software suite (mne-tools#12976) DOC: specify tmax_raw param may be None, and what it means (mne-tools#12972) [pre-commit.ci] pre-commit autoupdate (mne-tools#12975) DOC: fix note in legacy pick_channels func (mne-tools#12973) Use `uint16_codec` argument (mne-tools#12971) Bump codecov/codecov-action from 4 to 5 in the actions group (mne-tools#12970) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work now that pyvista/setup-headless-display-action#21 is in