Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow get_entity_vals to ignore sidecars #1362

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

drammock
Copy link
Member

@drammock drammock commented Jan 2, 2025

closes #1351

PR Description

adds a new parameter ignore_suffixes to get_entity_vals so that sidecars (scans, coordsystem) may easily be ignored.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.42%. Comparing base (8334fc6) to head (6fb4708).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
+ Coverage   97.40%   97.42%   +0.01%     
==========================================
  Files          40       40              
  Lines        8915     8922       +7     
==========================================
+ Hits         8684     8692       +8     
+ Misses        231      230       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drammock
Copy link
Member Author

drammock commented Jan 2, 2025

All green, ready for review/merge

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sappelhoff sappelhoff merged commit 41ce36a into mne-tools:main Jan 3, 2025
23 checks passed
@drammock drammock deleted the ignore-suffixes branch January 7, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_entity_vals should ignore sidecars
2 participants