[MRG] _return_root_paths now only looks in subfolders of root starting with 'sub-'

[kaare-mikkelsen]

PR Description

In relation to this issue: #1127

I now submit this pull request. It's a pretty simple solution - after calling root.rglob(pattern), returned paths are filtered such that only those starting with root / 'sub-' are sent on.

This closes #1127

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

• All comments are resolved
• This is not your own PR
• All CIs are happy
• PR title starts with [MRG]
• whats_new.rst is updated
• New contributors have been added to CITATION.cff
• PR description includes phrase "closes <#issue-number>"

[welcome]

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

[kaare-mikkelsen]

so, I can see that my commit fails a lot of tests, despite being a very minor change? besides changing the length of line 2444 to be compatible with the style guide, what else should I do?

[sappelhoff]

@kaare-mikkelsen there were some unrelated failures that should now be fixed in main. I have merged these changes into your branch -- let's see how the CI comes back.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.45%. Comparing base (87eea28) to head (a92016a).
Report is 26 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
- Coverage   97.61%   97.45%   -0.17%     
==========================================
  Files          40       40              
  Lines        8685     8687       +2     
==========================================
- Hits         8478     8466      -12     
- Misses        207      221      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hoechenberger]

@sappelhoff We should probably set up the autofix.ci bot to make contributors' lives easier

[sappelhoff]

@kaare-mikkelsen I plan to have a look at this within the next three weeks -- thanks for your patience!

[sappelhoff]

please see #1281, which replaces this PR.