Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for optional Z in time strs #1240

Merged
merged 9 commits into from
Mar 25, 2024
Merged

account for optional Z in time strs #1240

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e1dd99e
account for optional Z in time strs
sappelhoff Mar 20, 2024
563af7b
Try to handle UTC zero offset and local time zones correctly
hoechenberger Mar 25, 2024
d02c8ef
Fix comment
hoechenberger Mar 25, 2024
34f8490
Fix
hoechenberger Mar 25, 2024
5ffa7c5
Better variable name
hoechenberger Mar 25, 2024
164dd4f
Add tests
hoechenberger Mar 25, 2024
8566784
Update mne_bids/read.py
hoechenberger Mar 25, 2024
9227312
Add changelog entry
hoechenberger Mar 25, 2024
f907308
Merge branch 'time' of https://github.com/sappelhoff/mne-bids into pr…
hoechenberger Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mne_bids/read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,8 @@
if "." not in acq_time:
# acquisition time ends with '.%fZ' microseconds string
acq_time += ".0Z"
if "Z" not in acq_time:
hoechenberger marked this conversation as resolved.
Show resolved Hide resolved
acq_time += "Z"

Check warning on line 335 in mne_bids/read.py

View check run for this annotation

Codecov / codecov/patch

mne_bids/read.py#L335 

Added line #L335 was not covered by tests
acq_time = datetime.strptime(acq_time, "%Y-%m-%dT%H:%M:%S.%fZ")
acq_time = acq_time.replace(tzinfo=timezone.utc)

Expand Down
Loading