fix: New factory binding doesn't reset a cached value

mnasyrov · Jun 2, 2024 · 01b3dad · 01b3dad
1 parent 997ca44
commit 01b3dad
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/packages/ditox/src/container.test.ts b/packages/ditox/src/container.test.ts
@@ -272,6 +272,32 @@ describe('Container', () => {
       expect(container.get(CONTAINER)).toBe(container);
       expect(container.get(PARENT_CONTAINER)).toBe(parent);
     });
+
+    it('should rebind a value binding by the same token', () => {
+      const container = createContainer();
+
+      container.bindValue(NUMBER, 1);
+      container.bindFactory(NUMBER, () => 2);
+      expect(container.get(NUMBER)).toBe(2);
+    });
+
+    it('should rebind a factory binding by the same token', () => {
+      const container = createContainer();
+
+      container.bindFactory(NUMBER, () => 1);
+      container.bindFactory(NUMBER, () => 2);
+      expect(container.get(NUMBER)).toBe(2);
+    });
+
+    it('should rebind a factory binding with cached value by the same token', () => {
+      const container = createContainer();
+
+      container.bindFactory(NUMBER, () => 1);
+      expect(container.get(NUMBER)).toBe(1);
+
+      container.bindFactory(NUMBER, () => 2);
+      expect(container.get(NUMBER)).toBe(2);
+    });
   });
 
   describe('remove()', () => {

diff --git a/packages/ditox/src/container.ts b/packages/ditox/src/container.ts
@@ -165,6 +165,7 @@ export function createContainer(parentContainer?: Container): Container {
       }
 
       factories.set(token.symbol, {factory, options});
+      values.delete(token.symbol);
     },
 
     remove<T>(token: Token<T>): void {