Colorful refactoring #304
Merged
Colorful refactoring #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pheazant
approved these changes
Apr 16, 2024
| { | ||
| return gfx_loadteamcoloredimage(gSprites, filename, 255, 0, 255, 255, fVertical, fWrap); | ||
| return gfx_loadteamcoloredimage(sprites, path, colors::MAGENTA, 255, fVertical, fWrap); |
There was a problem hiding this comment.
I'm nitpicking, but it being magenta is probably not the important thing about 0xff00ff in this case. What is important is that it is the background color.
There was a problem hiding this comment.
You are correct, and this is why the parameter name in gfxSprite::init is key (from color key) instead of just RGB. However, some images use a different color key, for example black; calling 0xff00ff then as 'transparent' would be misleading, so I went with the color names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.