Removed leftover script calling in the Settings code

mmatyas · Sep 2, 2018 · 4175609 · 4175609
1 parent 2948c0f
commit 4175609
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 17 deletions.
diff --git a/src/backend/model/settings/Settings.cpp b/src/backend/model/settings/Settings.cpp
@@ -20,7 +20,6 @@
 #include "AppArgs.h"
 #include "LocaleUtils.h"
 #include "Paths.h"
-#include "ScriptRunner.h"
 
 #include <QDebug>
 #include <QDir>
@@ -56,12 +55,7 @@ Settings::Settings(QObject* parent)
     , m_locales(this)
     , m_themes(this)
     , m_providers(this)
-{
-    connect(&m_locales, &LocaleList::localeChanged,
-            this, &Settings::callScripts);
-    connect(&m_themes, &ThemeList::themeChanged,
-            this, &Settings::callScripts);
-}
+{}
 
 void Settings::setFullscreen(bool new_val)
 {
@@ -74,13 +68,6 @@ void Settings::setFullscreen(bool new_val)
     emit fullscreenChanged();
 }
 
-void Settings::callScripts()
-{
-    using ScriptEvent = ScriptRunner::EventType;
-    ScriptRunner::findAndRunScripts(ScriptEvent::CONFIG_CHANGED);
-    ScriptRunner::findAndRunScripts(ScriptEvent::SETTINGS_CHANGED);
-}
-
 QStringList Settings::gameDirs() const
 {
     QSet<QString> dirset;

diff --git a/src/backend/model/settings/Settings.h b/src/backend/model/settings/Settings.h
@@ -57,9 +57,6 @@ class Settings : public QObject {
     void fullscreenChanged();
     void gameDirsChanged();
 
-private slots:
-    void callScripts();
-
 private:
     LocaleList m_locales;
     ThemeList m_themes;