Fixes primefaces#15112 - Give list role instead of listbox to items l…

…ist when empty
mlz11 · Mar 25, 2024 · 68d1f1d · 68d1f1d
1 parent 7e17d57
commit 68d1f1d
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/app/components/dropdown/dropdown.ts b/src/app/components/dropdown/dropdown.ts
@@ -22,7 +22,6 @@ import {
     Renderer2,
     Signal,
     signal,
-    SimpleChanges,
     TemplateRef,
     ViewChild,
     ViewEncapsulation,
@@ -266,7 +265,15 @@ export class DropdownItem {
                             </ng-container>
 
                             <ng-template #buildInItems let-items let-scrollerOptions="options">
-                                <ul #items [attr.id]="id + '_list'" [attr.aria-label]="listLabel" class="p-dropdown-items" [ngClass]="scrollerOptions.contentStyleClass" [style]="scrollerOptions.contentStyle" role="listbox">
+                                <ul
+                                    #items
+                                    [attr.id]="id + '_list'"
+                                    [attr.aria-label]="listLabel"
+                                    class="p-dropdown-items"
+                                    [ngClass]="scrollerOptions.contentStyleClass"
+                                    [style]="scrollerOptions.contentStyle"
+                                    [attr.role]="isEmpty() ? 'list' : 'listbox'"
+                                >
                                     <ng-template ngFor let-option [ngForOf]="items" let-i="index">
                                         <ng-container *ngIf="isOptionGroup(option)">
                                             <li class="p-dropdown-item-group" [attr.id]="id + '_' + getOptionIndex(i, scrollerOptions)" [ngStyle]="{ height: scrollerOptions.itemSize + 'px' }" role="option">