Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract internal tuned values in instance #164

Merged
merged 3 commits into from
Oct 16, 2024
Merged

refactor: extract internal tuned values in instance #164

merged 3 commits into from
Oct 16, 2024

Conversation

be-marc
Copy link
Member

@be-marc be-marc commented Oct 14, 2024

No description provided.

@sumny
Copy link
Member

sumny commented Oct 14, 2024

Is it expected that tests currently fail against development versions of mlr3tuning etc.? Fix itself seems reasonable, so in general, feel free to merge and thanks for fixing :)

Edit: failing is probably expected due to needing mlr-org/mlr3tuning@extract_internal, right?

@be-marc
Copy link
Member Author

be-marc commented Oct 15, 2024

Edit: failing is probably expected due to needing mlr-org/mlr3tuning@extract_internal, right?

Yes our dev runs always install mlr3tuning@main

@be-marc be-marc merged commit 3de4d0c into main Oct 16, 2024
7 checks passed
@be-marc be-marc deleted the xydt branch October 16, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants