You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
think about introducing async loop function that would allow OptmizerAdbo to behave similar as OptimizerMbo
If not moving forward with async loop function, maybe still allow OptimizerAdbo to be configured w.r.t surrogate and acquisition function optimizer.
Note that update logic w.r.t missing values was dropped in feat: bbotk async compatibility #146 and should be moved to OptimizerAdbo or async loop functions directly
the Surrogate learner code was already slightly underdocumented, the PR adds even more code here. It is not documented at all what this does. I think this is for imputing points which are currently under evaluation. I am not sure if we should mix that in.... at the very least this needs to be documented and commented
the SurrogateLearner is now tightly coupled with rush, and its imputation for async optim. I think this is not good design. Inherit from SL, create SLAsync. only do the impute there, don't touch the existing class.
we have to handle failed stated. but MBO should ALREADY cover that? just use the same mechanism.
we might slightly change the impute mechanism. we could a) sample between min/max b) instead of mean provide a "quantile value" which is constantly used (e.g. 0.5 would always use median). in any case, a reference should be provided?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.