Skip to content

Commit

Permalink
Merge pull request #168 from advieser/fix/hash
Browse files Browse the repository at this point in the history
fix:: calculating hash
  • Loading branch information
mb706 authored Sep 24, 2024
2 parents da037e1 + 19c5b2d commit a43d4e3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Added `FilterUnivariateCox` (thanks to @bblodfon)
- Parameter value `na.rm` is properly initialized to `TRUE` (thanks to @bblodfon)
- Bugfix: property `missings` is now set correctly for `FilterFindCorrelation`
- Bugfix: `$hash` now works for `Filter`s

# mlr3filters 0.7.1

Expand Down
4 changes: 4 additions & 0 deletions R/Filter.R
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ Filter = R6Class("Filter",
assert_ro_binding(rhs)
calculate_hash(class(self), self$id, mget(private$.extra_hash, envir = self))
}
),

private = list(
.extra_hash = character()
)
)

Expand Down

0 comments on commit a43d4e3

Please sign in to comment.