Skip to content

Commit

Permalink
Advice lispyville-end-of-defun to go past defuns
Browse files Browse the repository at this point in the history
`lispyville-end-of-defun' doesn't go to the next defun when point is
already at the end of a defun, whereas `lispyville-beginning-of-defun'
does. This commit fixes this inconsistency by matching
`lispyville-end-of-defun''s behaviour with `lispyville-beginning-of-defun'.

`line-end-position' isn't enough because it never returns `t' in normal
mode (in normal mode the point can't reach the true end of a line).
  • Loading branch information
Leo Okawa Ericson committed May 26, 2021
1 parent 6c2ff37 commit 3b18153
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion modules/editor/lispy/config.el
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,14 @@
additional
additional-insert))
:config
(lispyville-set-key-theme))
(lispyville-set-key-theme)
;; REVIEW Delete this once https://github.com/noctuid/lispyville/pull/297 is merged
(defadvice! +lispy--fix-lispyville-end-of-defun-a (_)
"lispyville-end-of-defun doesn't go to the next defun when
point is already at the end of a defun, whereas
lispyville-beginning-of-defun does."
:before #'lispyville-end-of-defun
(when (<= (- (line-end-position)
(point))
1)
(forward-line))))

0 comments on commit 3b18153

Please sign in to comment.