Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Accessible Read Indicator Setting to Post Settings #1627

Merged
merged 5 commits into from
Jan 19, 2025

Conversation

Sjmarf
Copy link
Member

@Sjmarf Sjmarf commented Jan 19, 2025

I think this is better because it means that we have one less link on the main settings page, and users who want to change this setting will still be able to find it in Post Settings pretty easily. The setting is only shown if Differentiate Without Color is on.

If we end up adding more accessibility settings we could always add the page back and duplicate the setting into that page too.

Also minor tweaks to animations for the other post settings

@Sjmarf Sjmarf requested a review from a team as a code owner January 19, 2025 14:42
@Sjmarf Sjmarf requested review from EricBAndrews and removed request for a team January 19, 2025 14:42
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like duplicating this setting into post settings, but don't want to get rid of the Accessibility page--there are a couple more accessibility settings we had in v1 that we should include for 2.0 (#1629, #1630)

@Sjmarf
Copy link
Member Author

Sjmarf commented Jan 19, 2025

Fair enough; I'll put it back 👍

@Sjmarf Sjmarf requested a review from EricBAndrews January 19, 2025 16:48
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Sjmarf Sjmarf enabled auto-merge (squash) January 19, 2025 17:45
@Sjmarf Sjmarf merged commit 9c91c96 into dev Jan 19, 2025
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/differentiate-without-color-setting branch January 19, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants