Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact user token from error toast #1471

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Redact user token from error toast #1471

merged 2 commits into from
Dec 4, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Dec 1, 2024

Closes #1453

@Sjmarf Sjmarf requested a review from a team as a code owner December 1, 2024 15:13
@Sjmarf Sjmarf requested review from WestonHanners and EricBAndrews and removed request for a team December 1, 2024 15:13
EricBAndrews
EricBAndrews approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@Sjmarf Sjmarf enabled auto-merge (squash) December 4, 2024 10:08
@Sjmarf Sjmarf merged commit 71220d2 into dev Dec 4, 2024
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/error-token-redact branch December 4, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

@WestonHanners WestonHanners Awaiting requested review from WestonHanners WestonHanners is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redact user token from error popup
2 participants
@Sjmarf @EricBAndrews