Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLED theme tweaks #1468

Merged
merged 2 commits into from
Dec 4, 2024
Merged

OLED theme tweaks #1468

merged 2 commits into from
Dec 4, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Nov 30, 2024 •
edited
Loading

  • Changed the form shadow radius to 1px so that it looks like a solid border
  • Added missing .paletteBorder cases
  • Fixed tappable link text alignment (closes Easy tap link title alignment #1462)

@Sjmarf Sjmarf requested a review from a team as a code owner November 30, 2024 23:21
@Sjmarf Sjmarf requested review from JakeShirley and mormaer and removed request for a team November 30, 2024 23:21
EricBAndrews
EricBAndrews approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

That's a pretty clean hack to fix the "glow"

@Sjmarf Sjmarf enabled auto-merge (squash) December 4, 2024 09:59
@Sjmarf Sjmarf merged commit df6760d into dev Dec 4, 2024
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/styling-tweaks branch December 4, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

@JakeShirley JakeShirley Awaiting requested review from JakeShirley JakeShirley is a code owner automatically assigned from mlemgroup/mlem-dev-team

@mormaer mormaer Awaiting requested review from mormaer mormaer is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easy tap link title alignment
2 participants
@Sjmarf @EricBAndrews