Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact user token from error popup #1453

Closed
Sjmarf opened this issue Nov 25, 2024 · 0 comments · Fixed by #1471
Closed

Redact user token from error popup #1453

Sjmarf opened this issue Nov 25, 2024 · 0 comments · Fixed by #1471
Assignees
@Sjmarf
Milestone
v2.0

Comments

@Sjmarf
Copy link
Contributor

Sjmarf commented Nov 25, 2024

Under certain circumstances the error popup can include the URL which caused the error, which in turn contains the user's token. We should redact the token from the error message if so, in case they post the error message somewhere.
@Sjmarf Sjmarf added the enhancement New feature or request label Nov 25, 2024
@Sjmarf Sjmarf added this to the v2.0 milestone Nov 25, 2024
@Sjmarf Sjmarf removed the enhancement New feature or request label Nov 26, 2024
@Sjmarf Sjmarf mentioned this issue Dec 1, 2024
Merged
@Sjmarf Sjmarf self-assigned this Dec 1, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Finished in Development Tracker Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sjmarf Sjmarf

Labels
None yet
Projects
Development Tracker
Status: Finished
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Redact user token from error toast mlemgroup/mlem
1 participant
@Sjmarf