Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eric/inbox feed loader #74

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Eric/inbox feed loader #74

wants to merge 11 commits into from

Conversation

EricBAndrews
Copy link
Member

[!NOTE] Still in draft while I finalize and bugfix, but the basic architecture is all in place.

Major divergences from the old approach:

  • Merging is now done in the Fetcher; this enables much more reuse of the StandardFeedLoader logic
  • Child loaders can only have one parent. We never used the multi-parent functionality of the old approach, and having only one avoids a lot of nasty recursion cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant