Conformer workload variants #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
…gorithmic-efficiency into conformer_workload_variants
priyakasimbeg
changed the title
priyakasimbeg
changed the title
priyakasimbeg
changed the title
znado
previously approved these changes
Dec 7, 2023
priyakasimbeg
dismissed
znado’s stale review
The merge-base changed after approval.
priyakasimbeg
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after Criteo variants PR/568
Add Conformer workload variants:
Added modeldiff compare tests for the variants.
Note that for GELU in PyTorch we have to override to the default 'approximate' arg to specify the tanh approximation which is used by default in the JAX GELU implementation.