Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade torch and torchvision #564

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Upgrade torch and torchvision #564

merged 7 commits into from
Nov 15, 2023

Conversation

priyakasimbeg
Copy link
Contributor

@priyakasimbeg priyakasimbeg commented Nov 7, 2023 •
edited
Loading

Disable torch compile ViT due to #496.
Triggered regression test and checked that everything passed here: https://github.com/mlcommons/algorithmic-efficiency/actions/runs/6820449633/job/18577174826.

I have retimed the pytorch workloads w the NVIDIA driver update on 2.0.1 and 2.1.0 and the workloads are roughly the same, most < 1% diff. Measured percentage difference of new vs old (projected) submission times on adamw:

  2.0.1 2.1.0 2.0.1 2.1.0 speedup (%)
  submission time (s) submission time (s) (h) (h)  
criteo1tb_adamw 7393.555594 7279.994981 2.053765443 2.022220828 -1.54
fastmri_adamw 9606.619108 9699.320933 2.668505308 2.694255815 0.96
imagenet_resnet_adamw 65771.35937 67761.1296 18.26982205 18.822536 3.03
imagenet_vit_adamw 74314.54125 74500.57515 20.64292812 20.69460421 0.25
librispeech_conformer_adamw 84465.78128 83725.16328 23.46271702 23.2569898 -0.88
librispeech_deepspeech_adamw 57857.49604 57557.82885 16.07152668 15.98828579 -0.52
ogbg_adamw 26449.03248 26557.22344 7.346953466 7.377006511 0.41
wmt_adamw 55315.73472 54366.63234 15.36548187 15.10184232 -1.72

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the base branch from main to dev November 10, 2023 23:19
@priyakasimbeg priyakasimbeg changed the title [do not merge] upgrade torch and torchvision Upgrade torch and torchvision Nov 10, 2023
@priyakasimbeg priyakasimbeg requested a review from znado November 10, 2023 23:20
@priyakasimbeg priyakasimbeg marked this pull request as ready for review November 10, 2023 23:20
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner November 10, 2023 23:20
msaroufim
msaroufim approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, will take a look at compile issues next

@priyakasimbeg priyakasimbeg merged commit a8b2502 into dev Nov 15, 2023
49 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@pomonam pomonam deleted the pytorch_upgrade branch November 28, 2023 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@msaroufim msaroufim msaroufim approved these changes

@znado znado Awaiting requested review from znado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priyakasimbeg @msaroufim