Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scoring issues #561

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Fix scoring issues #561

merged 5 commits into from
Nov 3, 2023

Conversation

runame
Copy link
Contributor

@runame runame commented Nov 3, 2023

Resolves #555.

Please check if the fixes address all four points mentioned in the issue as intended.

Notes:

  • I have removed the tabulate requirement, see my comment here.
  • I changed some import statements and file paths to absolute paths within the repo. Not sure if there was a reason to not do that previously, can undo if necessary.

@runame runame added 🐛 Bug Something isn't working 🚀 Launch Blocker Issues that are blocking launch of benchmark P1 Launch 2023 High priority issues for October 2023 AlgoPerf Launch labels Nov 3, 2023
@runame runame requested a review from priyakasimbeg November 3, 2023 16:54
@runame runame requested a review from a team as a code owner November 3, 2023 16:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg
Copy link
Contributor

LGTM! Thanks Runa!

@priyakasimbeg priyakasimbeg merged commit 0943802 into mlcommons:dev Nov 3, 2023
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
@runame runame deleted the scoring branch January 11, 2024 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@priyakasimbeg priyakasimbeg priyakasimbeg approved these changes

Assignees
No one assigned
Labels
🐛 Bug Something isn't working 🚀 Launch Blocker Issues that are blocking launch of benchmark P1 Launch 2023 High priority issues for October 2023 AlgoPerf Launch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runame @priyakasimbeg