Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for setting pytorch max_split_size_mb #559

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

priyakasimbeg
Copy link
Contributor

@priyakasimbeg priyakasimbeg commented Oct 31, 2023

The conformer pytorch workload still may run out of memory in current state.
Add reduce_pytorch_max_split_size as a temporary workaround in case people into this issue. This will set 'max_split_size_mb:256'. Note that this will adversely impact the performance of the submission on this workload. See tracking issue.
Also minor formatting changes in other files.

Copy link

github-actions bot commented Oct 31, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the title Add flag for setting Add flag for setting pytorhc max_split_size_mb Oct 31, 2023
@priyakasimbeg priyakasimbeg changed the title Add flag for setting pytorhc max_split_size_mb Add flag for setting pytorch max_split_size_mb Oct 31, 2023
pomonam
pomonam previously approved these changes Nov 2, 2023
Copy link
Contributor

@pomonam pomonam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

submission_runner.py Outdated Show resolved Hide resolved
submission_runner.py Outdated Show resolved Hide resolved
@priyakasimbeg priyakasimbeg marked this pull request as ready for review November 2, 2023 22:17
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner November 2, 2023 22:17
@priyakasimbeg priyakasimbeg merged commit 4fe66bf into dev Nov 2, 2023
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
@priyakasimbeg priyakasimbeg deleted the pytorch_flag branch November 2, 2023 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants