Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update speech targets #538

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Update speech targets #538

merged 1 commit into from
Oct 10, 2023

Conversation

priyakasimbeg
Copy link
Contributor

Update speech targets after fixing mistake in internal procedure.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the title update speech targets Update speech targets Oct 9, 2023
@priyakasimbeg priyakasimbeg marked this pull request as ready for review October 9, 2023 22:42
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner October 9, 2023 22:42
sourabh2k15
sourabh2k15 requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@sourabh2k15 sourabh2k15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you verify internal deepspeech test/wer targets once ? everything else looks good

@priyakasimbeg
Copy link
Contributor Author

Checked that everything internally was correct.

@priyakasimbeg priyakasimbeg merged commit 28da089 into dev Oct 10, 2023
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
sourabh2k15
sourabh2k15 reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@sourabh2k15 sourabh2k15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad test targets are also correct! approved

@priyakasimbeg priyakasimbeg deleted the speech_targets_update branch November 2, 2023 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sourabh2k15 sourabh2k15 sourabh2k15 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priyakasimbeg @sourabh2k15