Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RNG seed flag to submission runner #514

Merged
merged 10 commits into from
Sep 21, 2023
Merged

Add RNG seed flag to submission runner #514

merged 10 commits into from
Sep 21, 2023

Conversation

priyakasimbeg
Copy link
Contributor

@priyakasimbeg priyakasimbeg commented Sep 19, 2023 •
edited
Loading

For #279.

Add rng_seed flag to submission runner.
Save rng_seed in metadata.json file.

Also pin ml_dtypes version as temporary work around for jax dependency issue jax-ml/jax#17693.

@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg marked this pull request as ready for review September 19, 2023 21:54
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner September 19, 2023 21:54
znado
znado requested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@znado znado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to override rng_seed on L557 in the self tuning rule set

@priyakasimbeg
Copy link
Contributor Author

we also need to override rng_seed on L557 in the self tuning rule set

@znado good catch. Fixed!

@priyakasimbeg priyakasimbeg requested a review from znado September 20, 2023 23:15
@priyakasimbeg priyakasimbeg merged commit d3fcbb6 into dev Sep 21, 2023
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
@priyakasimbeg priyakasimbeg deleted the rng_seed_flag branch October 4, 2023 01:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pomonam pomonam Awaiting requested review from pomonam

@znado znado Awaiting requested review from znado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priyakasimbeg @znado