Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requests version #943

Merged
merged 8 commits into from
Sep 22, 2024

Conversation

benmalef
Copy link
Contributor

Fixes #872

Proposed Changes

  • Update the requests to 2.32.2.

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

Copy link
Contributor

github-actions bot commented Sep 22, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@benmalef benmalef marked this pull request as ready for review September 22, 2024 09:04
@benmalef benmalef requested a review from a team as a code owner September 22, 2024 09:04
@benmalef benmalef changed the title Change requests version Update requests version to 2.32.2 Sep 22, 2024
@sarthakpati sarthakpati changed the title Update requests version to 2.32.2 Update requests version Sep 22, 2024
@sarthakpati sarthakpati merged commit 4ef185d into mlcommons:master Sep 22, 2024
19 of 20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update to new docker-py dependency once released
3 participants