Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious errors in OpenFL Github Actions workflow #934

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

psfoley
Copy link
Contributor

@psfoley psfoley commented Sep 10, 2024

Resolves Github Actions change to FQDN

Proposed Changes

  • Adds environment variable to OpenFL Github Actions test to resolve FQDN to localhost instead of >64 length FQDN they have migrated to

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • [] Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

Resolves Github Actions change to FQDN
@psfoley psfoley requested a review from a team as a code owner September 10, 2024 22:56
Copy link
Contributor

github-actions bot commented Sep 10, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@psfoley
Copy link
Contributor Author

psfoley commented Sep 10, 2024

recheck

@sarthakpati
Copy link
Collaborator

Thanks, @psfoley!

@sarthakpati sarthakpati merged commit b678958 into mlcommons:master Sep 11, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants