Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use torchmetric PSNR implementation and argument ordering #693

Merged
merged 22 commits into from
Aug 2, 2023

Commits on Jul 18, 2023

  1. Used proper torchmetric parameter order and replaced own PSNR impleme…

    …ntation with torchmetric PSNR
    
    - I replaced the self-implemented PSNR computation with the one provided by torchmetric. 
    - The ordering of torchmetric function call arguments is actually predictions ("preds") and then target ("target"), not the other way around.
    FelixSteinbauer authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    5409c32 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Configuration menu
    Copy the full SHA
    dcb35a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Configuration menu
    Copy the full SHA
    9b4add6 View commit details
    Browse the repository at this point in the history
  2. Added peak_signal_noise_ratio_eps as dicussed

    peak_signal_noise_ratio_eps with the initial PSNR implementation (using range and epsilon)
    FelixSteinbauer authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    00ea9c5 View commit details
    Browse the repository at this point in the history
  3. Added peak_signal_noise_ratio_eps call for synthesis case.

    Additionally to the vanilla PSNR, also the PSNR based on value range and with epsilon in the denominator is now added to the overall_stats_dict as "psnr_range_eps"
    FelixSteinbauer authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    960e47a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e3e36d7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0e2d72e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    5dee4ec View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Configuration menu
    Copy the full SHA
    08aac5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ffbaa7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af8c12d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b42ca4e View commit details
    Browse the repository at this point in the history
  5. Fixed: unmatched ")"

    FelixSteinbauer authored Jul 29, 2023
    Configuration menu
    Copy the full SHA
    fdea518 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d2bf127 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    acef5d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    9472f06 View commit details
    Browse the repository at this point in the history
  2. Fixed wrong parenthesis in PSR definition

    Co-authored-by: Sarthak Pati <[email protected]>
    FelixSteinbauer and sarthakpati authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    5be2fca View commit details
    Browse the repository at this point in the history
  3. Trying different quotation marks

    I don't know why changing this comment broke the testing pipeline. Maybe it was not the comment. I changed the quotation marks hoping that would help (probably does not though...)
    FelixSteinbauer authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    70f8ff5 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    dfa1665 View commit details
    Browse the repository at this point in the history
  2. Trying to revert parenthesis fix

    Now the code should be in the state when it last worked
    FelixSteinbauer authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    5f584af View commit details
    Browse the repository at this point in the history
  3. Returned to current state of code

    I do not know why the pipeline fails To me it seems unrelated to the changes that were made since the last successful run.
    FelixSteinbauer authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d8b1f8d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Configuration menu
    Copy the full SHA
    974fde4 View commit details
    Browse the repository at this point in the history