-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use torchmetric PSNR implementation and argument ordering #693
Merged
Commits on Jul 18, 2023
-
Used proper torchmetric parameter order and replaced own PSNR impleme…
…ntation with torchmetric PSNR - I replaced the self-implemented PSNR computation with the one provided by torchmetric. - The ordering of torchmetric function call arguments is actually predictions ("preds") and then target ("target"), not the other way around.
Configuration menu - View commit details
-
Copy full SHA for 5409c32 - Browse repository at this point
Copy the full SHA 5409c32View commit details
Commits on Jul 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dcb35a3 - Browse repository at this point
Copy the full SHA dcb35a3View commit details
Commits on Jul 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9b4add6 - Browse repository at this point
Copy the full SHA 9b4add6View commit details -
Added peak_signal_noise_ratio_eps as dicussed
peak_signal_noise_ratio_eps with the initial PSNR implementation (using range and epsilon)
Configuration menu - View commit details
-
Copy full SHA for 00ea9c5 - Browse repository at this point
Copy the full SHA 00ea9c5View commit details -
Added peak_signal_noise_ratio_eps call for synthesis case.
Additionally to the vanilla PSNR, also the PSNR based on value range and with epsilon in the denominator is now added to the overall_stats_dict as "psnr_range_eps"
Configuration menu - View commit details
-
Copy full SHA for 960e47a - Browse repository at this point
Copy the full SHA 960e47aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3e36d7 - Browse repository at this point
Copy the full SHA e3e36d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e2d72e - Browse repository at this point
Copy the full SHA 0e2d72eView commit details
Commits on Jul 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5dee4ec - Browse repository at this point
Copy the full SHA 5dee4ecView commit details
Commits on Jul 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 08aac5f - Browse repository at this point
Copy the full SHA 08aac5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ffbaa7 - Browse repository at this point
Copy the full SHA 3ffbaa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for af8c12d - Browse repository at this point
Copy the full SHA af8c12dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b42ca4e - Browse repository at this point
Copy the full SHA b42ca4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdea518 - Browse repository at this point
Copy the full SHA fdea518View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2bf127 - Browse repository at this point
Copy the full SHA d2bf127View commit details -
Configuration menu - View commit details
-
Copy full SHA for acef5d8 - Browse repository at this point
Copy the full SHA acef5d8View commit details
Commits on Jul 31, 2023
-
Different description (comment) for non-torchmetrics PSNR
Co-authored-by: Sarthak Pati <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9472f06 - Browse repository at this point
Copy the full SHA 9472f06View commit details -
Fixed wrong parenthesis in PSR definition
Co-authored-by: Sarthak Pati <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5be2fca - Browse repository at this point
Copy the full SHA 5be2fcaView commit details -
Trying different quotation marks
I don't know why changing this comment broke the testing pipeline. Maybe it was not the comment. I changed the quotation marks hoping that would help (probably does not though...)
Configuration menu - View commit details
-
Copy full SHA for 70f8ff5 - Browse repository at this point
Copy the full SHA 70f8ff5View commit details
Commits on Aug 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dfa1665 - Browse repository at this point
Copy the full SHA dfa1665View commit details -
Trying to revert parenthesis fix
Now the code should be in the state when it last worked
Configuration menu - View commit details
-
Copy full SHA for 5f584af - Browse repository at this point
Copy the full SHA 5f584afView commit details -
Returned to current state of code
I do not know why the pipeline fails To me it seems unrelated to the changes that were made since the last successful run.
Configuration menu - View commit details
-
Copy full SHA for d8b1f8d - Browse repository at this point
Copy the full SHA d8b1f8dView commit details
Commits on Aug 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 974fde4 - Browse repository at this point
Copy the full SHA 974fde4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.