feat: chex-ify testsuite
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariG23498
requested changes
Oct 9, 2024
jflux/cli.py
Outdated
Comment on lines
218
to
219
| img = Image.fromarray((127.5 * (x + 1.0))) | ||
| img.save(fn, quality=95, subsampling=0) |
There was a problem hiding this comment.
Thanks for doing this.
I am doing this
x = (127.5 * (x + 1.0))
x_numpy = np.array(x.astype(jnp.uint8))
img = Image.fromarray(x_numpy)
img.save(fn, quality=95, subsampling=0)
idx += 1Can you add this bit in this PR?
There was a problem hiding this comment.
Added in 07cf60a
jflux/util.py
Outdated
There was a problem hiding this comment.
in port_flux we are missing a return statement
Could you add return flux
There was a problem hiding this comment.
Added in 9bd82d6
| @@ -32,7 +32,10 @@ jflux = { workspace = true } | |||
| flux = { git = "https://github.com/black-forest-labs/flux.git" } | |||
|
|
|||
| [tool.ruff.lint] | |||
| select = ["I001"] | |||
| select = ["E", "F", "I001", "W"] | |||
There was a problem hiding this comment.
Just asking -- what does this do?
There was a problem hiding this comment.
So previously, we weren't utilising most of the nice ruff rules. This snippet enables some nice rules from https://docs.astral.sh/ruff/rules/
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.pre-commit-config.yaml.READMEinstructions for running the cli..vscode/settings.jsonwith a simple vscode config.jflux/__main__.py.E,FandW.chex-ify testsuite.