use sys.executable to run robot #584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasjani
force-pushed
the
module-based-execution
branch
2 times, most recently
from
bb87096
to
0b3a2d8
Compare
mkorpela
approved these changes
May 23, 2024
Fixes mkorpela#578 Rationale for this change: * one could use start-command / end-command but optional rebot call would still be executed via executable * automatic RobotStackTrace would not be added if start-command / end-command was used. Optional --sysexecutable could be removed and functionality of current change be made a sole calling mechanism since existing code is already importing robot to determine version. This sort of makes assumption that pabot and robot are installed in under same python interpreter and usage of executable wrappers is purely optional ?
rasjani
force-pushed
the
module-based-execution
branch
from
0b3a2d8
to
7767fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #578
Rationale for this change:
Optional --sysexecutable could be removed and functionality of current change be made a sole calling mechanism since existing code is already importing robot to determine version. This sort of makes assumption that pabot and robot are installed in under same python interpreter and usage of executable wrappers is purely optional ?