Support for reading error cells and non-numeric formula cells #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding method for Cell/CELL_TYPE_ERROR (The only unhandled cell type) Returns keyword value of the FormulaError Enumeration i.e. one of the following: :VALUE :DIV0 :CIRCULAR_REF :REF :NUM :NULL :FUNCTION_NOT_IMPLEMENTED :NAME :NA
…ultimethod DateUtil/isCellDateFormatted is only valid for numeric type cells. So need to check this after evaluation of the formula when we know the type of cell value. Previously calling read-cell on a formula cell that evaluated to anything other than a numeric value resulted in an IllegalStateException.
This was referenced Mar 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes discussed in issue #32.
read-cellsupports error cells (returning keyword corresponding to type)read-cellcan read non-numeric formula cellsOn successful merge. Pull requests #7 #8 #11 #31 and issues #21 #27 #32 can be closed.