Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use of the isort linter #515

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Add use of the isort linter #515

merged 2 commits into from
Aug 19, 2023

Conversation

JohnVillalovos
Copy link
Contributor

No description provided.

In previous versions of `tox` it made sense to use `envdir` to have
multiple test environments share the same directory when they had the
same requirements.

But since `tox>=4` it no longer makes sense to do this as now `tox`
will detect a difference and keep recreating the environment and cause
it to be slower than having separate environments. What is happening
now is if you run `tox -e black,flake8` it will create the
environments. Then run `tox -e black,flake8` again it will again
recreate the environments. By removing `envdir` it won't recreate the
environments on the second and subsequent runs.
  * Add the `isort` linter https://pycqa.github.io/isort/
  * Add a `tox` environment to run `isort`
  * Enable it in the GitHub CI
  * Run it on all the code.
Copy link
Owner

@mjs mjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks!

@mjs mjs merged commit b9284e4 into mjs:master Aug 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants