chore: remove envdir settings from tox.ini
#514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous versions of `tox` it made sense to use `envdir` to have multiple test environments share the same directory when they had the same requirements. But since `tox>=4` it no longer makes sense to do this as now `tox` will detect a difference and keep recreating the environment and cause it to be slower than having separate environments. What is happening now is if you run `tox -e black,flake8` it will create the environments. Then run `tox -e black,flake8` again it will again recreate the environments. By removing `envdir` it won't recreate the environments on the second and subsequent runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions of
toxit made sense to useenvdirto have multiple test environments share the same directory when they had the same requirements.But since
tox>=4it no longer makes sense to do this as nowtoxwill detect a difference and keep recreating the environment and cause it to be slower than having separate environments. What is happening now is if you runtox -e black,flake8it will create the environments. Then runtox -e black,flake8again it will again recreate the environments. By removingenvdirit won't recreate the environments on the second and subsequent runs.