Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI integration tests + do not do a node lookup for multi-value field_member_of #849

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Nov 14, 2024

Link to Github issue or other discussion

#848 and #747

What does this PR do?

  • Allows for multi-value field_member_of columns
  • Adds integration test in CI

What changes were made?

How to test / verify this PR?

Look at the new integration test CI results

Interested Parties

@mjordan


Checklist

  • Before opening this PR, have you opened an issue explaining what you want to to do?
  • Have you included some configuration and/or CSV files useful for testing this PR?
  • Have you written unit or integration tests if applicable?
  • Does the code added in this PR require a version of Python that is higher than the current minimum version?
  • If the changes in this PR require an additional Python library, have you included it in setup.py?
  • If the changes in this PR add a new configuration option, have you provided a default for when the option is not present in the .yml file?

@joecorall joecorall changed the title Do not do a node lookup for multi-value field_member_of CI integration tests + do not do a node lookup for multi-value field_member_of Nov 14, 2024
@joecorall joecorall marked this pull request as ready for review November 14, 2024 16:03
joecorall added a commit to lehigh-university-libraries/islandora_workbench that referenced this pull request Nov 14, 2024
@mjordan
Copy link
Owner

mjordan commented Nov 15, 2024

@joecorall islandora_tests_check.py failing is a known issue I started working on a while ago but put aside. Can you remove running that one for now?

@joecorall
Copy link
Contributor Author

joecorall commented Nov 15, 2024

@mjordan - i removed the islandora_tests_check.py test. Also made a few more changes to get the tests working on Mac OS and here in CI. Namely:

  • 3c737db - a lot of the test workbench configs have /tmp hardcoded in them. Since that's the case, and mac OS has a different system temp directory than /tmp I changed the value to be hardcoded
  • 6d9a948 - some of the islandora_tests.py tests were failing due to the CSV having comments in them that weren't nids. This makes sure only nids get written (and the file is freshly written to instead of appending if exists)

I realize this PR changes the way you were testing locally (replaces isle-dc assumptions with isle-site-template assumptions). Though to get the same setup as CI on your local machine you should be able to run:

git clone [email protected]:islandora-devops/isle-site-template ~/isle-site-template
cd ~/isle-site-template
export ISLANDORA_STARTER_OWNER=Islandora-Devops
export ISLANDORA_STARTER_REF=heads/main
export ISLANDORA_TAG=main
./tests/init-template-starter.sh
docker exec isle-site-template-drupal-dev-1 drush config:set media.settings standalone_url FALSE -y
docker exec isle-site-template-drupal-dev-1 drush cr

And adding the CA to python requests before running the paged content test

export REQUESTS_CA_BUNDLE=~/isle-site-template/certs/rootCA.pem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants