Optimized tooltip generation in WBaseWidget #13952
Conversation
Declared toQWidget const
| } | ||
| m_pWidget->setToolTip(debug.join("\n")); | ||
| m_pWidget->setToolTip(debug.join(QStringLiteral("\n"))); |
There was a problem hiding this comment.
| m_pWidget->setToolTip(debug.join(QStringLiteral("\n"))); | |
| m_pWidget->setToolTip(debug.join(QChar('\n'))); |
| } | ||
| for (const auto& pControlConnection : std::as_const(m_connections)) { | ||
| *debug << QString("Connection: %1").arg(pControlConnection->toDebugString()); | ||
| *debug << QStringLiteral("ClassName: %1") |
There was a problem hiding this comment.
since this is supposed to be an optimization, you may want to consider reserving space as appropriate. This adds quite a lot of elements, so it needs to reallocate at least once, avoiding the second allocation by reserving enough upfront may make sense.
| *debug << QStringLiteral("ClassName: %1") | |
| debug->reserve(debug.size() + 7 + m_leftConnections.size() + m_rightConnections.size() + m_connections.size() + 1); | |
| *debug << QStringLiteral("ClassName: %1") |
There was a problem hiding this comment.
The QStringBuilder does it implicit for us, if we replace the %1 placeholder by normal string concat using +.
However is it worth the efforts in this PR?
There was a problem hiding this comment.
debug is a QList<QString>. I don't see how QStringBuilder is relevant here.
There was a problem hiding this comment.
I mean
QStringLiteral("ObjectName: %1").arg(m_pWidget->objectName())
->
QStringLiteral("ObjectName: ") + m_pWidget->objectName()
There was a problem hiding this comment.
I don't think that makes a meaningful difference for a single argument
Code cleanup. Main change is that empty lines at the end of the tooltips are no longer printed.