Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salvage #13772 #13935

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Salvage #13772 #13935

wants to merge 6 commits into from

Commits on Nov 24, 2024

  1. Expose convertCharset convenience function to controller 

    Allow to convert from UTF-8 to whatever encoding the device supports
    @christophehenry
    christophehenry committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    58d8b98 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. simplify ControllerScriptInterfaceLegacy::convertCharset

    @Swiftb0y
    Swiftb0y committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d131d1c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. feat: add a couple more encodings to enum, don't throw on invalid codec

    @Swiftb0y
    Swiftb0y committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    57007c8 View commit details
    Browse the repository at this point in the history

  2. fix: don't convert invalid chars to null 

    Returning part of a usable result instead of nullbytes since
those likely terminate the string early or even corrupt the
underlying binary message format the buffer is embedded in.
    @Swiftb0y
    Swiftb0y committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    01b80a5 View commit details
    Browse the repository at this point in the history

  3. fix: test

    @Swiftb0y
    Swiftb0y committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    f876724 View commit details
    Browse the repository at this point in the history

  4. align closer with upstream

    @Swiftb0y
    Swiftb0y committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    e2c74a9 View commit details
    Browse the repository at this point in the history