RekordBoxFeature: add played functionality to rekordbox external library

[andreivn2]

Hello,

Because I use mixxx a lot for my DVS setup with rekordbox exports from different sources I decided to create this PR.

This PR introduces minimal and simple changes to the RekordboxFeature in order to display and correctly interpret the "played" column in the external library view.

All SQL modified is in regards to tables that are dropped and created with each restart of mixxx.
Changes are integrated with the current hierarchy of QAbstractDisplayTable.

[JoergAtGithub]

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

[andreivn2]

Welcome at Mixxx! As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

Done

[JoergAtGithub]

The pre-commit check is failing. The best way to fix pre-commit issues is to install pre-commit locally on your system, as described here: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking
Than it will fix these issues automatically before every commit.
Alternatively, you can download the pre-commit.patch file from the artifacts of this PR

unzip it, and apply it using:
git apply pre-commit.patch

[andreivn2]

Applied pre-commit patch now.

I tried to do it before creating the PR, but had some issues with it failing with some python exception.

[Swiftb0y]

couple nitpicky comments. I'm probably not the right person to do a proper review here because I'm not familiar enough with the database code.

[Swiftb0y]

rather than an in-memory set, have you considered adding a temporary table that stores the played track ids and then query against that here? That would result in improved scalability.

[andreivn2]

Ok, so innocently i tried to use GitHub's features for the comments I got and it messed up my commits.
History looks really bad now.
Should I just create a new branch with a new PR?

[Swiftb0y]

don't worry with that for now. we can clean up the history later. no need to open a new PR or create new branch.

[daschuer]

The History feature uses certain logic to prevent insain played numbers during scratching:

mixxx/src/library/trackset/setlogfeature.cpp

Line 615 in 359c40e

if (track_played_recently) {

I think it is a good idea to move this functionality into Playerinfo and feed both tables with the same value to have it consistent in all views.

[andreivn2]

If you think this fits within the scope of this PR i can try and make a commit later tonight