Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track Info Dialog: Improve keyboard usability & resize behavior #13818

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Track Info Dialog: Improve keyboard usability & resize behavior #13818

wants to merge 39 commits into from

Commits on Jun 22, 2024

  1. DlgTrackInfo/LastPlayed: Add "Last played" field to track info dialog

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f81e8d2 View commit details
    Browse the repository at this point in the history

  2. DlgTrackInfo/LastPlayed: Display placeholder for last played date

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    0eda4b9 View commit details
    Browse the repository at this point in the history

  3. DlgTrackInfo/Layout: Fix alignment of "Grouping" and "Comments" label 

    This makes these two labels have the same alignment and pixel position
(relative to their input control) as all the other labels in the dialog.
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    79b6d7f View commit details
    Browse the repository at this point in the history

  4. DlgTrackInfo/Cleanup: Fix: Make text of "Bitrate" field selectable 

    All other similar fields in the dialog are selectable, so this
seems to just have been an oversight.
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c00dfc9 View commit details
    Browse the repository at this point in the history

  5. DlgTrackInfo/Cleanup: Improve GroupBox names

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    9aa4ff0 View commit details
    Browse the repository at this point in the history

  6. DlgTrackInfo/Cleanup: Group related properties in the header

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2e5a11b View commit details
    Browse the repository at this point in the history

  7. DlgTrackInfo/Cleanup: Simplify updateTrackMetadataFields

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    9b9aa75 View commit details
    Browse the repository at this point in the history

  8. DlgTrackInfo/Cleanup: Associate read-only fields with track property … 

    …names
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f1f3089 View commit details
    Browse the repository at this point in the history

  9. WStarRating: Remove Qt5 compatibility code

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    25eb63c View commit details
    Browse the repository at this point in the history

  10. WStarRating: Add keyboard controls for modifying the star rating

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4b309a8 View commit details
    Browse the repository at this point in the history

  11. WStarRating: Highlight the control when having keyboard focus

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    43ef74b View commit details
    Browse the repository at this point in the history

  12. DlgTrackInfo/StarRating: Move UI setup code into the .ui file.

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ae81d1f View commit details
    Browse the repository at this point in the history

  13. DlgTrackInfo/StarRating: Integrate WStarRating into the tab order

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    5bef6d2 View commit details
    Browse the repository at this point in the history

  14. DlgTrackInfo/LeftRight: Conditionally enable/disable btnNext and btnPrev

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f60d4c2 View commit details
    Browse the repository at this point in the history

  15. DlgTrackInfo/LeftRight: Add Alt+Left / Alt+Right as additional shortc… 

    …uts for navigating between tracks
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ae797c2 View commit details
    Browse the repository at this point in the history

  16. DlgTrackInfo/LeftRight: Refocus the current widget when moving to a d… 

    …ifferent track
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    643533e View commit details
    Browse the repository at this point in the history

  17. DlgTrackInfo/Sizing: Scroll to start of text fields by setting the cu… 

    …rsor position
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    dcd791b View commit details
    Browse the repository at this point in the history

  18. DlgTrackInfo/Sizing: Add WMultiLineTextEdit to allow for correct resi… 

    …zing

Also fix the sizePolicy of other widgets, such that the "Comments"
field gets all available remaining vertical space.
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    891d021 View commit details
    Browse the repository at this point in the history

  19. WMultiLineTextEdit: Style like QLineEdit (including the focus frame)

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    3fba164 View commit details
    Browse the repository at this point in the history

  20. DlgTrackInfo/Sizing: Add WBasicPushButton to elide text

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    fe5c1f9 View commit details
    Browse the repository at this point in the history

  21. WBasicPushButton: Automatically generate tooltips when button is smal… 

    …ler than contents
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    395697b View commit details
    Browse the repository at this point in the history

  22. DlgTrackInfo/UpDown: Change focus when pressing Up/Down on WBasicLine… 

    …Edit
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4085793 View commit details
    Browse the repository at this point in the history

  23. DlgTrackInfo/UpDown: Change focus when pressing Up/Down on WMultiLine… 

    …TextField
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    239717d View commit details
    Browse the repository at this point in the history

  24. DlgTrackInfo/UpDown: Change focus when pressing Up/Down on WStarRating

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c6a016d View commit details
    Browse the repository at this point in the history

  25. DlgTrackInfo/UpDown: Change focus when pressing Up/Down on WBasicTabW… 

    …idget
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c83f4cb View commit details
    Browse the repository at this point in the history

  26. DlgTrackInfo/UpDown: Change focus when pressing Up/Down on WBasicLabel

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c0ff995 View commit details
    Browse the repository at this point in the history

  27. DlgTrackInfo/UpDown: Sort WBasicLabel controls by visual & tab order 

    This is needed to avoid breaking keyboard navigation in a few cases.
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a169351 View commit details
    Browse the repository at this point in the history

  28. DlgTrackInfo/ColorPicker: Avoid double-triggering the color picker popup 

    The menu is already automatically opened by QPushButton::pressed, no need
to do it twice. This caused problems when Enter is used to open the color
picker popup.
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    5b2424d View commit details
    Browse the repository at this point in the history

  29. WColorPicker: Fix oversight in idealColumnCount

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    d23e53d View commit details
    Browse the repository at this point in the history

  30. WColorPicker: Allow keyboard navigation in the color picker popup

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    42f0b14 View commit details
    Browse the repository at this point in the history

  31. WColorPicker: Set initially focused widget of color picker popup

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    3589e57 View commit details
    Browse the repository at this point in the history

  32. DlgTrackInfo: Add tooltip for cover image

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    dbf2da0 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge remote-tracking branch 'upstream/main' into ready-for-merge/tra… 

    …ck-info-dialog

Resolved conflicts caused by mixxxdj#13632 (Move metatdata buttons below color picker).
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8aa703f View commit details
    Browse the repository at this point in the history

  2. DlgTrackInfo: Rename meatdata_buttons_layout to metadata_buttons_layout

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a5ae64e View commit details
    Browse the repository at this point in the history

  3. WColorPicker: Fix code formatting issue in WColorGridButton constructor

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5ad242b View commit details
    Browse the repository at this point in the history

  4. DlgTrackInfo/Cleanup: Associate "rating" and "color" property names w… 

    …ith their corresponding edit controls
    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    25c005f View commit details
    Browse the repository at this point in the history

  5. DlgTrackInfoMulti/StarRating: Integrate WStarRating into the tab order

    @cr7pt0gr4ph7
    cr7pt0gr4ph7 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0f3fefd View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Use QKeyEvent::text() for handling Key_0..9 

    Co-authored-by: ronso0 <[email protected]>
    @cr7pt0gr4ph7 @ronso0
    cr7pt0gr4ph7 and ronso0 authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    335c4cb View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Use 'const' and QStringLiteral where possible 

    Co-authored-by: ronso0 <[email protected]>
    @cr7pt0gr4ph7 @ronso0
    cr7pt0gr4ph7 and ronso0 authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7266f4d View commit details
    Browse the repository at this point in the history