add notes about issues to fix and cleanup

mixxxdj · Nov 9, 2024 · 8d650e9 · 8d650e9
1 parent d8b2179
commit 8d650e9
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 11 deletions.
diff --git a/src/main.cpp b/src/main.cpp
@@ -85,6 +85,7 @@ int runMixxx(MixxxApplication* pApp, const CmdlineArgs& args) {
                     });
             exitCode = pApp->exec();
         }
+        // TODO destroy core services (controllers) before WaveformWidgetFactory
         WaveformWidgetFactory::destroy();
     } else
 #endif

diff --git a/src/waveform/renderers/allshader/waveformrendererendoftrack.h b/src/waveform/renderers/allshader/waveformrendererendoftrack.h
@@ -41,7 +41,6 @@ class allshader::WaveformRendererEndOfTrack final
 
     QColor m_color;
     PerformanceTimer m_timer;
-    bool m_hasRendered{false};
 
     DISALLOW_COPY_AND_ASSIGN(WaveformRendererEndOfTrack);
 };
diff --git a/src/waveform/renderers/allshader/waveformrendermarkrange.h b/src/waveform/renderers/allshader/waveformrendermarkrange.h
@@ -24,9 +24,6 @@ class allshader::WaveformRenderMarkRange final : public ::WaveformRendererAbstra
   public:
     explicit WaveformRenderMarkRange(WaveformWidgetRenderer* waveformWidget);
 
-    void clearRanges() {
-        m_markRanges.clear();
-    }
     void addRange(WaveformMarkRange&& range) {
         m_markRanges.push_back(std::move(range));
     }

diff --git a/src/waveform/renderers/waveformrendermarkbase.cpp b/src/waveform/renderers/waveformrendermarkbase.cpp
@@ -9,11 +9,6 @@ WaveformRenderMarkBase::WaveformRenderMarkBase(
         bool updateImagesImmediately)
         : WaveformRendererAbstract(pWaveformWidgetRenderer),
           m_updateImagesImmediately(updateImagesImmediately) {
-#ifdef __RENDERGRAPH_IS_SCENEGRAPH
-    m_marks.connectSamplePositionChanged(this, &WaveformRenderMarkBase::onMarkChanged);
-    m_marks.connectSampleEndPositionChanged(this, &WaveformRenderMarkBase::onMarkChanged);
-    m_marks.connectVisibleChanged(this, &WaveformRenderMarkBase::onMarkChanged);
-#endif
 }
 
 void WaveformRenderMarkBase::setup(const QDomNode& node, const SkinContext& context) {

diff --git a/src/waveform/renderers/waveformwidgetrenderer.cpp b/src/waveform/renderers/waveformwidgetrenderer.cpp
@@ -40,10 +40,9 @@ WaveformWidgetRenderer::WaveformWidgetRenderer(const QString& group)
           m_visualPlayPosition(nullptr),
           m_totalVSamples(0),
           m_pRateRatioCO(nullptr),
-          m_pContext(nullptr),
           m_pGainControlObject(nullptr),
-          m_gain(1.0),
           m_pTrackSamplesControlObject(nullptr),
+          m_gain(1.0),
           m_trackSamples(0.0),
           m_scaleFactor(1.0),
           m_playMarkerPosition(s_defaultPlayMarkerPosition),
-Original file line number
+Diff line change
@@ Expand Up @@
                         });
                 exitCode = pApp->exec();
             }
+            // TODO destroy core services (controllers) before WaveformWidgetFactory
             WaveformWidgetFactory::destroy();
         } else
     #endif
@@ Expand Down @@