Add component pre-init hook #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdumitrescu
reviewed
Feb 14, 2024
| @@ -470,6 +470,8 @@ class Component extends WebComponent { | |||
| } | |||
| } | |||
|
|
|||
| this.dispatchEvent(new CustomEvent(`preComponentInitialized`, {detail: {el: this}, bubbles: true, composed: true})); | |||
There was a problem hiding this comment.
Do you really need el: this? Surely you can get that from the event object already
There was a problem hiding this comment.
yeah actually, im not sure why but event.target doesn't always equal the dispatching component in the handler. sometimes it is different components altogether unless i pass it explicitly like this
There was a problem hiding this comment.
still much cleaner than the prototype / prop overriding but still a goot solution
tdumitrescu
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an event that's dispatched before first template call in Panel components.