forked from segmentio/action-destinations
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the properties for Mixpanel Actions #5
Open
zihejia
wants to merge
5
commits into
main
Choose a base branch
from
mixpanel-props-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zihejia
force-pushed
the
mixpanel-props-fixes
branch
2 times, most recently
from
October 27, 2022 18:03
b6bb8bc
to
8133cc5
Compare
zihejia
force-pushed
the
mixpanel-props-fixes
branch
from
October 27, 2022 22:25
8133cc5
to
2013e44
Compare
austinpray-mixpanel
pushed a commit
that referenced
this pull request
Jun 26, 2024
…gmentio#1340) * main (#5) * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Subscribe to more events (Redo without required type) (#986) * Add subscriptions to track event * Generate types and new snapshot * Add test * Improve labels and descriptions * Generated types * Change description * Generate types * Remove required * Generate types * Update Ripe web destination (#968) * Update Ripe web destination - Add new endpoint setting for testing purposes - Remove alias call - Update misleading anonymousId descriptions * Update erroneous default paths * Set anonymousId in identify call * Heap 34916 - add session_id + update segment library for tracking purposes (#787) * Fix events payload * Use the single event not the bulk * Fix tests * Fix should not override * remove console log and update SEGMENT_LIB var * update constant value * update browser tests as well * Adding Group support for customerio -Rename identifier field names (#973) * Initial commit for objects * Added Test cases * Adding Tests validation for the payload * committing generate type file * Adding group support from identify * Fixing conflicts * Adding traits to attributes property for createUpdateObject action * renaming id and type_id to object_id and object_type_id Co-authored-by: kishoredevarasettyn <[email protected]> * SalesWings (Actions) Destination (#945) * Generated integration from scaffold * Fix action name * Implement SalesWings destination actions * Send user agent, rearrange fields * Bugfixes * Remove debug logging * First tests * Auth tests & track event tests * Page event tests * Identify event tests * Screen event tests * Event batch test * More event batch tests * Change API key description * Commit generated types * Minor cleanup * Fix square brackets in field description UI * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Hardcoding timestamps for snapshot tests * Extract email from properties of Track event * Add action description * Add default subscription to action * Add destination present * Merge URL fields * Dedicated actions per event type * Cleanup * Update field descriptions * Update geenrated types Co-authored-by: Yevgeny Terov <[email protected]> Co-authored-by: Marín Alcaraz <[email protected]> Co-authored-by: Yevgeny Terov <[email protected]> * Changing default subscription to group for group call (#995) * Initial commit for objects * Added Test cases * Adding Tests validation for the payload * committing generate type file * Adding group support from identify * Fixing conflicts * Adding traits to attributes property for createUpdateObject action * setting default subscription as group for createUpdateObject and addressing other review comments * correcting merge overrides Co-authored-by: kishoredevarasettyn <[email protected]> * Add anonymous id as a user property (#981) * Update setting description in Google Ads Conversions (#983) * HGI-237 | Updated Description for Braze Cohorts Fields (#992) * udpated description for braze cohorts * updated description for braze cohorts * updated description in mapping fields * updated description * updated event_properties to hidden * made event_properties unhidden Co-authored-by: Gaurav Kochar <[email protected]> * Increase CI timeout to 15 minutes and 10 minutes respectively (#985) * Increase CI timeout to 15 minutes * Bump browser tests to 10 minutes Co-authored-by: Nolan Chan <[email protected]> * Pipedrive actions PE-20 (#996) * fix for pipedrive pe-20 issue * removing default visible_to * Register Saleswing Action (#999) Co-authored-by: Nolan Chan <[email protected]> * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * ACT-362 Brackets Support (#993) * add support for brackets inside js keys in get method * add double quotes * explanatory text + new link * safari support * remove invalid bracket test since it is now supported * use class based regex to avoid parseError * actually convert the regex correctly * cleanup * split tests by functionality * Refactor .get test (#1000) * Heap Fix for empty event name (#1004) * fix for pe-52 * fixing breaking tests * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * fix scaffolding for oauth (#1008) * [CHANNELS-329] Add WhatsApp support for Twilio Engage (#987) * feat: added whatsapp support * fix: added missing dependencies * refactor: minor cleanup * fix: moved dependency to package level * fix: uri encoding for get traits * fix: using same auth scheme for sms & whatsapp whatsApp thankfully allows using apiKeySid & apiSecret instead of accountSid & authToken * fix: reverted changed package version * feat: allow bypassing contentVariables reconciliation * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Add browser destination tests with saucelabs (#994) * Node 18 Upgrade (#991) * packages * ci + nvm * lock for 18 * fix webpack hashing issue * node types to 18 * Update node version for browser-tests and snyk * Fix tests * Try to fix browser tests * Fix pipedrive unit tests * Fix domain in snapshot tests * Fix yarn subscriptions * Update README --------- Co-authored-by: Dan Lasky <[email protected]> * Use node18 for browser tests destinations (#1014) * Contribution pe 53 (#1007) * updating contributing guidelines * adding extra instructions for post deployment changes * spelling corrections * spelling corrections * Update CONTRIBUTING.md Co-authored-by: SyedWasiHaider <[email protected]> * Update CONTRIBUTING.md Co-authored-by: SyedWasiHaider <[email protected]> --------- Co-authored-by: SyedWasiHaider <[email protected]> * Qualtrics upsert transaction (#963) * adding upsert contact transacion destination * fixing snapshots * Updating perform function for upsertTransaction * Adding dynamic fields for directoryId. Updating field descriptions. Update upsertTransaction defaultSubscription * updating types * Update qualtrics destination name and descriptons on actions --------- Co-authored-by: Carl Lee <[email protected]> * fixing a couple of issues with new Ironclad destination (#1002) * fixing a couple of issues with new Ironclad destination * adding updated generated types * fixing broken test * [salesforce] - Verify the `instanceUrl` is a valid Salesforce domain (#997) * Regex and WIP unit tests * Unit tests working * Updates regex and unit tests * Updates other unit tests * Saving package.json * Adds a couple more unit tests * Removes package.json from commits * Removes package.json from commits * Imports request client using absolute path instead of relative path * Enforce https * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Fix CommandBar browser destination initialization when CommandBar has already been loaded through other means (#1009) Co-authored-by: Thomas Kainrad <[email protected]> * remove flow that attempts to create a JIRA ticket (#1021) * Twilio Studio as a Segment Action Destination (#1023) * Twilio Studio as a Segment Action Destination * Replaced phone number with userid in the cache key * Addressed review comments * DOTORG-839: Blackbaud Raiser's Edge NXT Destination (#998) * DOTORG-839: Create or Update Individual Constituent Action (#1) * DOTORG-839 Added OAuth2 settings for Blackbaud (#2) * Move bbApiSubscriptionKey to settings * Only aggregate integrationErrors * Update Online Presence label * Update directory structure * Add types * Abstract API calls * Add dateStringToFuzzyDate * Add types * Don't retry 401s * Don't catch errors on constituent search or creation * Concatenate integrationErrors * Add throwHttpErrors * Set default for lookup_id to userId * Pass constituentId to updateConstituent * Remove try/catch * Use camelCase traits * Add filterObjectListByMatchFields * Check if primary property is defined * DOTORG-839 Added authentication test (#3) * Don't match on country * Use datetime type * Strip non-numeric characters from phone when matching * Don't match on undefined boolean fields * Update generated-types.ts * Fix linting errors * Move fixtures out of tests directory * Update constituentData * Update default lookup_id mapping * Update testAuthentication * Remove UNEXPECTED_RECORD_COUNT error * Update tests --------- Co-authored-by: twilio-hwong <[email protected]> --------- Co-authored-by: Nick Aguilar <[email protected]> Co-authored-by: Stella Chung <[email protected]> Co-authored-by: Simon <[email protected]> Co-authored-by: A Murphy <[email protected]> Co-authored-by: kishoredevarasettyn <[email protected]> Co-authored-by: kishoredevarasettyn <[email protected]> Co-authored-by: Denis Egorushkin <[email protected]> Co-authored-by: Yevgeny Terov <[email protected]> Co-authored-by: Marín Alcaraz <[email protected]> Co-authored-by: Yevgeny Terov <[email protected]> Co-authored-by: maryamsharif <[email protected]> Co-authored-by: Innovative-GauravKochar <[email protected]> Co-authored-by: Gaurav Kochar <[email protected]> Co-authored-by: Nolan Chan <[email protected]> Co-authored-by: Joe Ayoub <[email protected]> Co-authored-by: Nolan Chan <[email protected]> Co-authored-by: Dan <[email protected]> Co-authored-by: Seth Silesky <[email protected]> Co-authored-by: rhall-twilio <[email protected]> Co-authored-by: alfrimpong <[email protected]> Co-authored-by: SyedWasiHaider <[email protected]> Co-authored-by: Dan Lasky <[email protected]> Co-authored-by: drakauskas <[email protected]> Co-authored-by: Carl Lee <[email protected]> Co-authored-by: Wasi Haider <[email protected]> Co-authored-by: Thomas Kainrad <[email protected]> Co-authored-by: Thomas Kainrad <[email protected]> Co-authored-by: aradhakrishnan-twilio <[email protected]> Co-authored-by: twilio-hwong <[email protected]> * main (#7) * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Subscribe to more events (Redo without required type) (#986) * Add subscriptions to track event * Generate types and new snapshot * Add test * Improve labels and descriptions * Generated types * Change description * Generate types * Remove required * Generate types * Update Ripe web destination (#968) * Update Ripe web destination - Add new endpoint setting for testing purposes - Remove alias call - Update misleading anonymousId descriptions * Update erroneous default paths * Set anonymousId in identify call * Heap 34916 - add session_id + update segment library for tracking purposes (#787) * Fix events payload * Use the single event not the bulk * Fix tests * Fix should not override * remove console log and update SEGMENT_LIB var * update constant value * update browser tests as well * Adding Group support for customerio -Rename identifier field names (#973) * Initial commit for objects * Added Test cases * Adding Tests validation for the payload * committing generate type file * Adding group support from identify * Fixing conflicts * Adding traits to attributes property for createUpdateObject action * renaming id and type_id to object_id and object_type_id Co-authored-by: kishoredevarasettyn <[email protected]> * SalesWings (Actions) Destination (#945) * Generated integration from scaffold * Fix action name * Implement SalesWings destination actions * Send user agent, rearrange fields * Bugfixes * Remove debug logging * First tests * Auth tests & track event tests * Page event tests * Identify event tests * Screen event tests * Event batch test * More event batch tests * Change API key description * Commit generated types * Minor cleanup * Fix square brackets in field description UI * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Hardcoding timestamps for snapshot tests * Extract email from properties of Track event * Add action description * Add default subscription to action * Add destination present * Merge URL fields * Dedicated actions per event type * Cleanup * Update field descriptions * Update geenrated types Co-authored-by: Yevgeny Terov <[email protected]> Co-authored-by: Marín Alcaraz <[email protected]> Co-authored-by: Yevgeny Terov <[email protected]> * Changing default subscription to group for group call (#995) * Initial commit for objects * Added Test cases * Adding Tests validation for the payload * committing generate type file * Adding group support from identify * Fixing conflicts * Adding traits to attributes property for createUpdateObject action * setting default subscription as group for createUpdateObject and addressing other review comments * correcting merge overrides Co-authored-by: kishoredevarasettyn <[email protected]> * Add anonymous id as a user property (#981) * Update setting description in Google Ads Conversions (#983) * HGI-237 | Updated Description for Braze Cohorts Fields (#992) * udpated description for braze cohorts * updated description for braze cohorts * updated description in mapping fields * updated description * updated event_properties to hidden * made event_properties unhidden Co-authored-by: Gaurav Kochar <[email protected]> * Increase CI timeout to 15 minutes and 10 minutes respectively (#985) * Increase CI timeout to 15 minutes * Bump browser tests to 10 minutes Co-authored-by: Nolan Chan <[email protected]> * Pipedrive actions PE-20 (#996) * fix for pipedrive pe-20 issue * removing default visible_to * Register Saleswing Action (#999) Co-authored-by: Nolan Chan <[email protected]> * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * ACT-362 Brackets Support (#993) * add support for brackets inside js keys in get method * add double quotes * explanatory text + new link * safari support * remove invalid bracket test since it is now supported * use class based regex to avoid parseError * actually convert the regex correctly * cleanup * split tests by functionality * Refactor .get test (#1000) * Heap Fix for empty event name (#1004) * fix for pe-52 * fixing breaking tests * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * fix scaffolding for oauth (#1008) * [CHANNELS-329] Add WhatsApp support for Twilio Engage (#987) * feat: added whatsapp support * fix: added missing dependencies * refactor: minor cleanup * fix: moved dependency to package level * fix: uri encoding for get traits * fix: using same auth scheme for sms & whatsapp whatsApp thankfully allows using apiKeySid & apiSecret instead of accountSid & authToken * fix: reverted changed package version * feat: allow bypassing contentVariables reconciliation * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Add browser destination tests with saucelabs (#994) * Node 18 Upgrade (#991) * packages * ci + nvm * lock for 18 * fix webpack hashing issue * node types to 18 * Update node version for browser-tests and snyk * Fix tests * Try to fix browser tests * Fix pipedrive unit tests * Fix domain in snapshot tests * Fix yarn subscriptions * Update README --------- Co-authored-by: Dan Lasky <[email protected]> * Use node18 for browser tests destinations (#1014) * Contribution pe 53 (#1007) * updating contributing guidelines * adding extra instructions for post deployment changes * spelling corrections * spelling corrections * Update CONTRIBUTING.md Co-authored-by: SyedWasiHaider <[email protected]> * Update CONTRIBUTING.md Co-authored-by: SyedWasiHaider <[email protected]> --------- Co-authored-by: SyedWasiHaider <[email protected]> * Qualtrics upsert transaction (#963) * adding upsert contact transacion destination * fixing snapshots * Updating perform function for upsertTransaction * Adding dynamic fields for directoryId. Updating field descriptions. Update upsertTransaction defaultSubscription * updating types * Update qualtrics destination name and descriptons on actions --------- Co-authored-by: Carl Lee <[email protected]> * fixing a couple of issues with new Ironclad destination (#1002) * fixing a couple of issues with new Ironclad destination * adding updated generated types * fixing broken test * [salesforce] - Verify the `instanceUrl` is a valid Salesforce domain (#997) * Regex and WIP unit tests * Unit tests working * Updates regex and unit tests * Updates other unit tests * Saving package.json * Adds a couple more unit tests * Removes package.json from commits * Removes package.json from commits * Imports request client using absolute path instead of relative path * Enforce https * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Fix CommandBar browser destination initialization when CommandBar has already been loaded through other means (#1009) Co-authored-by: Thomas Kainrad <[email protected]> * remove flow that attempts to create a JIRA ticket (#1021) * Twilio Studio as a Segment Action Destination (#1023) * Twilio Studio as a Segment Action Destination * Replaced phone number with userid in the cache key * Addressed review comments * DOTORG-839: Blackbaud Raiser's Edge NXT Destination (#998) * DOTORG-839: Create or Update Individual Constituent Action (#1) * DOTORG-839 Added OAuth2 settings for Blackbaud (#2) * Move bbApiSubscriptionKey to settings * Only aggregate integrationErrors * Update Online Presence label * Update directory structure * Add types * Abstract API calls * Add dateStringToFuzzyDate * Add types * Don't retry 401s * Don't catch errors on constituent search or creation * Concatenate integrationErrors * Add throwHttpErrors * Set default for lookup_id to userId * Pass constituentId to updateConstituent * Remove try/catch * Use camelCase traits * Add filterObjectListByMatchFields * Check if primary property is defined * DOTORG-839 Added authentication test (#3) * Don't match on country * Use datetime type * Strip non-numeric characters from phone when matching * Don't match on undefined boolean fields * Update generated-types.ts * Fix linting errors * Move fixtures out of tests directory * Update constituentData * Update default lookup_id mapping * Update testAuthentication * Remove UNEXPECTED_RECORD_COUNT error * Update tests --------- Co-authored-by: twilio-hwong <[email protected]> * Google Analytics 4 Web Destination (#1012) * addPaymentInfo Action * ga4 types, properties, and functions * set config fields action poc * set config fields action poc * GA4 all action created * Remove unit test cases files * Added defaultSubscription tag in viewItemList and generateLead Action * added register code for GA4 in broweser-destinations * add customEvent action * set config action & custom event action * Delete snapshot.test.ts * Delete index.test.ts * clean up & add mappings for preset * updated types and removed picklist * Added test cases for GA4 actions * Added test cases * added custom event unit test + cleaned up merge issues and commented code * fixed typo * add back ripe and commandbar to index file * added comment on non using variable * Apply suggestions from code review Co-authored-by: Neek Sandhu <[email protected]> * revert set configuration field actions * added updateUser function, and updated event to payload * reverted back gtag function and datalayer setup * add gtag type and remove comment * update yarn.lock file * add viewItemList & disable linter for args * remove gtag.js type dependency * update unit tests * added events to defaultSubscriptions * update index.js --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Neek Sandhu <[email protected]> * livelike-cloud action destination (PE-41) (#1020) * created livelike-cloud action destination with one trackEvent action and three presets and added unit tests * Update packages/destination-actions/src/destinations/livelike-cloud/trackEvent/index.ts Co-authored-by: Joe Ayoub <[email protected]> --------- Co-authored-by: Joe Ayoub <[email protected]> * Qualtrics - Fixed timezone issue in unit test (#1026) * Fixed timezone issue in unit test * refactored to use dayjs from lib * generate types (#1028) * PE-47 - Merge Algolia Insights (#1027) * Algolia insights integration (#975) * feat: initial commit after scaffold * feat: clarify insights API and impliment as distinct actions * test: write test for conversion destination * test: write test for click and view destination * test: write auth schema test * create productClick presets * add presets to destination * create all event presets * remove default imports for actions * add testAuthentication method for algolia-insights --------- Co-authored-by: Beatrice Parfait <[email protected]> * fixing snapshots and replacing userId and anonId with userToken * fixing timestamps in tests --------- Co-authored-by: Wesley Walser <[email protected]> Co-authored-by: Beatrice Parfait <[email protected]> * VWO Cloud Mode Description changes (#1015) * Description changes and changes in utility * Tests altered for new format * Update CODEOWNERS (#1029) * [HEAP-38485] Move to the integrations endpoint (#1016) * [HEAP-32036] First trackEvent implementation (#8) * [HEAP-32037] Send identify and add user properties requests (#9) * [HEAP-32037] Add user properties and migrate anonymous users * Hash anonymous user ID * Use message ID as idempotency key * Throw if parameters are missing * [HEAP-32884] backport filtering event properties (#10) * [HEAP-32884] backport filtering event properties - flat properties from the request payload before sending them to heap * address comments: - remove the embeded object under the util.ts, move it to flattenObj - remove unnecessary tests on identifyUser - import and use the embeded object and flatten object in trackEvent and identifyUser test not part of comments: - rename the file from flattenObj to flat * PR comments * Update packages/destination-actions/src/destinations/heap/trackEvent/index.ts Co-authored-by: Marín Alcaraz <[email protected]> * Update packages/destination-actions/src/destinations/heap/trackEvent/index.ts Co-authored-by: Marín Alcaraz <[email protected]> * Update packages/destination-actions/src/destinations/heap/trackEvent/index.ts Co-authored-by: Marín Alcaraz <[email protected]> * Update packages/destination-actions/src/destinations/heap/trackEvent/index.ts Co-authored-by: Marín Alcaraz <[email protected]> * remove unused file * save changes * save * fix library * remove accidental file * update tests * remove session id * PR comments * fix the tests * add user properties if more that one identifier is present * Revert "add user properties if more that one identifier is present" This reverts commit bb4fb94684be54c933e9375ae1fc877e876fbbd1. --------- Co-authored-by: Gediminas Rapolavicius <[email protected]> Co-authored-by: Yiyang Li <[email protected]> Co-authored-by: Marín Alcaraz <[email protected]> Co-authored-by: murphpdx <[email protected]> * Launchpad Segment Integration (#1010) * Launchpad Segment Integration We are now adding the ability to send events from segment into Launchpad.pm - the mission control for Product teams at scale. We are adding the following: * trackEvent * groupIdentifyUser * identifyUser We have added unit tests and have tested this manually. It requires the following: * apiRegion - EU by default. We have added the US as means of future extensibility. * apiSecret - given by Launchpad.pm while onboarding. * sourceName - to be added. * updating snapshots * Changes implemented following call with Joe Track() [x] Explicitly indicate which fields are required or optional [x] Look for traits and if not context.traits [x] Need description for the Action [x] Make Timestamp field required [x] Make messageId required. It will always be there. [x] getEventProperties: This line looks incorrect: id: payload.event, [x] source mapping looks incorrect: source: integration?.name == 'Iterable' ? 'Iterable' : 'segment', Identify() [x] Description should be updated. [x] identify() calls are often fired when a trait is collected, or when a userId is collected. [x] Maybe use wording: “Creates or updates a user profile, and adds or updates trait values on the user profile…” [x] Refactor the perform() function group() [x] Group Key - Amend description to better explain that group key is a way to connect multiple organizations together [x] groupId field - Should be updated [x] Consider adding anonymousId as a field [x] Handle when there are no traits. * changes * tests passing, removed the check on user_id, anonymous_id since none are required * fixing the types as well * fixing test --------- Co-authored-by: joe-ayoub-segment <[email protected]> * [STRATCONN-1950] Init new destination `Pinterest Conversions API` (#1030) * Init new destination `Pinterest Conversions API` * Update index.ts * Update index.ts * Update index.ts --------- Co-authored-by: rvadera12 <[email protected]> * Try to only pass in NODE_OPTIONS for node18+ (#1032) * Try using conditional for scripts * Remove NODE_OPTIONS from else * Echo the nodeversion * Try setting the node major version and testing that * Use correct variable in condition * Try a different approach * Use bash instead * Try to fix script * Add other remaining scripts * Changing name of new Algolia Insights Integration (#1038) * Register new action destinations (#1036) * Register new action destinations: Launchpad, Livelike Cloud, Twilio Studio, BlackBaud Raisers Edge Nxt, Pinterest Conversions Api * Fix path * add action to pinterest conversions api * add action to pinterest conversions api * add description to pinterest action * Register algolia insights (Actions) --------- Co-authored-by: rvadera12 <[email protected]> * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Use correct defaultPath for messageId (#1041) * Google ads v11 to v12 (#1018) * gooogle conversion v12 upgrade * changes * bug fix for test cases * gooogle conversion v12 upgrade * changes * bug fix for test cases * flag name changes * flag name change in test cases * review changes * revert ga4-types file change * revert ga4-types file change * revert ga4-types file change --------- Co-authored-by: manoj kumar <[email protected]> * [STRATCONN-1779]Add datadog stats for google ads api version (#1046) * adds stats for api version * adds missing statscontext parameter to getCustomVariables * refactor params * Voucherify-Segment.io Integration using action-destinations (#970) * initial destination configuration * identify customer action * add trackEvent * Generate screenEvent and pageEvent * Change the structure of track, page and screen events. * Delete test folder for now * Change the type definition * Delete timestamp * create group event * removed created_at property * hit to localhost address * Add unit tests * Some fixes * Change the URLs in perform method * Update URLs in tests * Delete unused testing authentication fn * Add snapshots * Add ability to pass a custom URL * Set type to required in page and screen events * Delete snapshots * Replace api endpoint (with regions) with custom URL * if there's no userId then use the anonymousId * removed space * added type property to rest of events * changed name of property 'name' to 'event' * Update index.ts * Update generated-types.ts * Delete unnecessary test - 'should throw an error when the name is not provided using page event' * Delete the 'voucherify' prefix * Slightly change the descriptions * generated types * Separate URL functions into separate files Change the file names to be more descriptive. * Reduce the getVoucherifyEndpointURL function * delete * Update the descriptions - Also deleted the 'event' prop from screen/page events and now the 'name' in screen/page event is no longer required. * Commit the generated types * Reduce the number of events to three. Track Custom Event, Identify Customer, Add group to customer metadata * Add customer attributes to traits in upsertCustomer action * Update generated-types.ts * Add testAuthentication * Update names of actions in unit tests * add firstName and lastName * Add email to custom event processing * Delete email from upsertCustomer (leave it only in traits) * Add email to description * Add email to customer processing * Update testAuthentication * update addCustomEvent * Update packages/destination-actions/src/destinations/voucherify/upsertCustomer/index.ts Co-authored-by: Joe Ayoub <[email protected]> * Fix issue with mapping the user attributes and improve Presets * generate types * change email properties * generated types * custom url information * generated types * Update the desc of Custom URL * minor changes from last PR * Update index.ts --------- Co-authored-by: Patryk Smolarz <[email protected]> Co-authored-by: Patryk Smolarz <[email protected]> Co-authored-by: Joe Ayoub <[email protected]> * HGI 372 - Fix Segment Profiles Destination (#1047) * Added `All: false` in Tracking API event * Changed PAPI Token field from `string` to `password` * Fixed minor typos * HGI-368 | Fixed the missing x-signature in request header when batching is enabled (#1043) * worked on HGI-368 Fix * added a unit test case for same fix --------- Co-authored-by: Gaurav Kochar <[email protected]> * Mixpanel destination: use user-agent for browser data (#1035) * remove device manufacturer - use user-agent * userAgent is only sent on web * New SalesWings API urls (#1039) * Use new SalesWings API urls * Do not check response status in testAuthentication * Fix testAuthentication * Remove unused file --------- Co-authored-by: Nick Aguilar <[email protected]> Co-authored-by: Stella Chung <[email protected]> Co-authored-by: Simon <[email protected]> Co-authored-by: A Murphy <[email protected]> Co-authored-by: kishoredevarasettyn <[email protected]> Co-authored-by: kishoredevarasettyn <[email protected]> Co-authored-by: Denis Egorushkin <[email protected]> Co-authored-by: Yevgeny Terov <[email protected]> Co-authored-by: Marín Alcaraz <[email protected]> Co-authored-by: Yevgeny Terov <[email protected]> Co-authored-by: maryamsharif <[email protected]> Co-authored-by: Innovative-GauravKochar <[email protected]> Co-authored-by: Gaurav Kochar <[email protected]> Co-authored-by: Nolan Chan <[email protected]> Co-authored-by: Joe Ayoub <[email protected]> Co-authored-by: Nolan Chan <[email protected]> Co-authored-by: Dan <[email protected]> Co-authored-by: Seth Silesky <[email protected]> Co-authored-by: rhall-twilio <[email protected]> Co-authored-by: alfrimpong <[email protected]> Co-authored-by: SyedWasiHaider <[email protected]> Co-authored-by: Dan Lasky <[email protected]> Co-authored-by: drakauskas <[email protected]> Co-authored-by: Carl Lee <[email protected]> Co-authored-by: Wasi Haider <[email protected]> Co-authored-by: Thomas Kainrad <[email protected]> Co-authored-by: Thomas Kainrad <[email protected]> Co-authored-by: aradhakrishnan-twilio <[email protected]> Co-authored-by: twilio-hwong <[email protected]> Co-authored-by: rvadera12 <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Neek Sandhu <[email protected]> Co-authored-by: Abhishek Kansal <[email protected]> Co-authored-by: Sayan Das <[email protected]> Co-authored-by: Wesley Walser <[email protected]> Co-authored-by: Beatrice Parfait <[email protected]> Co-authored-by: Prathamesh Tamanekar <[email protected]> Co-authored-by: Gediminas Rapolavicius <[email protected]> Co-authored-by: Yiyang Li <[email protected]> Co-authored-by: murphpdx <[email protected]> Co-authored-by: Stefan Sabev <[email protected]> Co-authored-by: Logan Luque <[email protected]> Co-authored-by: rvadera12 <[email protected]> Co-authored-by: Logan Luque <[email protected]> Co-authored-by: immanojkumar <[email protected]> Co-authored-by: manoj kumar <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: weronika-kurczyna <[email protected]> Co-authored-by: Patryk Smolarz <[email protected]> Co-authored-by: Patryk Smolarz <[email protected]> Co-authored-by: Sonya Park <[email protected]> * main (#9) * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Subscribe to more events (Redo without required type) (#986) * Add subscriptions to track event * Generate types and new snapshot * Add test * Improve labels and descriptions * Generated types * Change description * Generate types * Remove required * Generate types * Update Ripe web destination (#968) * Update Ripe web destination - Add new endpoint setting for testing purposes - Remove alias call - Update misleading anonymousId descriptions * Update erroneous default paths * Set anonymousId in identify call * Heap 34916 - add session_id + update segment library for tracking purposes (#787) * Fix events payload * Use the single event not the bulk * Fix tests * Fix should not override * remove console log and update SEGMENT_LIB var * update constant value * update browser tests as well * Adding Group support for customerio -Rename identifier field names (#973) * Initial commit for objects * Added Test cases * Adding Tests validation for the payload * committing generate type file * Adding group support from identify * Fixing conflicts * Adding traits to attributes property for createUpdateObject action * renaming id and type_id to object_id and object_type_id Co-authored-by: kishoredevarasettyn <[email protected]> * SalesWings (Actions) Destination (#945) * Generated integration from scaffold * Fix action name * Implement SalesWings destination actions * Send user agent, rearrange fields * Bugfixes * Remove debug logging * First tests * Auth tests & track event tests * Page event tests * Identify event tests * Screen event tests * Event batch test * More event batch tests * Change API key description * Commit generated types * Minor cleanup * Fix square brackets in field description UI * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Add mandatory `.` to description Co-authored-by: Marín Alcaraz <[email protected]> * Hardcoding timestamps for snapshot tests * Extract email from properties of Track event * Add action description * Add default subscription to action * Add destination present * Merge URL fields * Dedicated actions per event type * Cleanup * Update field descriptions * Update geenrated types Co-authored-by: Yevgeny Terov <[email protected]> Co-authored-by: Marín Alcaraz <[email protected]> Co-authored-by: Yevgeny Terov <[email protected]> * Changing default subscription to group for group call (#995) * Initial commit for objects * Added Test cases * Adding Tests validation for the payload * committing generate type file * Adding group support from identify * Fixing conflicts * Adding traits to attributes property for createUpdateObject action * setting default subscription as group for createUpdateObject and addressing other review comments * correcting merge overrides Co-authored-by: kishoredevarasettyn <[email protected]> * Add anonymous id as a user property (#981) * Update setting description in Google Ads Conversions (#983) * HGI-237 | Updated Description for Braze Cohorts Fields (#992) * udpated description for braze cohorts * updated description for braze cohorts * updated description in mapping fields * updated description * updated event_properties to hidden * made event_properties unhidden Co-authored-by: Gaurav Kochar <[email protected]> * Increase CI timeout to 15 minutes and 10 minutes respectively (#985) * Increase CI timeout to 15 minutes * Bump browser tests to 10 minutes Co-authored-by: Nolan Chan <[email protected]> * Pipedrive actions PE-20 (#996) * fix for pipedrive pe-20 issue * removing default visible_to * Register Saleswing Action (#999) Co-authored-by: Nolan Chan <[email protected]> * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * ACT-362 Brackets Support (#993) * add support for brackets inside js keys in get method * add double quotes * explanatory text + new link * safari support * remove invalid bracket test since it is now supported * use class based regex to avoid parseError * actually convert the regex correctly * cleanup * split tests by functionality * Refactor .get test (#1000) * Heap Fix for empty event name (#1004) * fix for pe-52 * fixing breaking tests * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * fix scaffolding for oauth (#1008) * [CHANNELS-329] Add WhatsApp support for Twilio Engage (#987) * feat: added whatsapp support * fix: added missing dependencies * refactor: minor cleanup * fix: moved dependency to package level * fix: uri encoding for get traits * fix: using same auth scheme for sms & whatsapp whatsApp thankfully allows using apiKeySid & apiSecret instead of accountSid & authToken * fix: reverted changed package version * feat: allow bypassing contentVariables reconciliation * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Add browser destination tests with saucelabs (#994) * Node 18 Upgrade (#991) * packages * ci + nvm * lock for 18 * fix webpack hashing issue * node types to 18 * Update node version for browser-tests and snyk * Fix tests * Try to fix browser tests * Fix pipedrive unit tests * Fix domain in snapshot tests * Fix yarn subscriptions * Update README --------- Co-authored-by: Dan Lasky <[email protected]> * Use node18 for browser tests destinations (#1014) * Contribution pe 53 (#1007) * updating contributing guidelines * adding extra instructions for post deployment changes * spelling corrections * spelling corrections * Update CONTRIBUTING.md Co-authored-by: SyedWasiHaider <[email protected]> * Update CONTRIBUTING.md Co-authored-by: SyedWasiHaider <[email protected]> --------- Co-authored-by: SyedWasiHaider <[email protected]> * Qualtrics upsert transaction (#963) * adding upsert contact transacion destination * fixing snapshots * Updating perform function for upsertTransaction * Adding dynamic fields for directoryId. Updating field descriptions. Update upsertTransaction defaultSubscription * updating types * Update qualtrics destination name and descriptons on actions --------- Co-authored-by: Carl Lee <[email protected]> * fixing a couple of issues with new Ironclad destination (#1002) * fixing a couple of issues with new Ironclad destination * adding updated generated types * fixing broken test * [salesforce] - Verify the `instanceUrl` is a valid Salesforce domain (#997) * Regex and WIP unit tests * Unit tests working * Updates regex and unit tests * Updates other unit tests * Saving package.json * Adds a couple more unit tests * Removes package.json from commits * Removes package.json from commits * Imports request client using absolute path instead of relative path * Enforce https * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Fix CommandBar browser destination initialization when CommandBar has already been loaded through other means (#1009) Co-authored-by: Thomas Kainrad <[email protected]> * remove flow that attempts to create a JIRA ticket (#1021) * Twilio Studio as a Segment Action Destination (#1023) * Twilio Studio as a Segment Action Destination * Replaced phone number with userid in the cache key * Addressed review comments * DOTORG-839: Blackbaud Raiser's Edge NXT Destination (#998) * DOTORG-839: Create or Update Individual Constituent Action (#1) * DOTORG-839 Added OAuth2 settings for Blackbaud (#2) * Move bbApiSubscriptionKey to settings * Only aggregate integrationErrors * Update Online Presence label * Update directory structure * Add types * Abstract API calls * Add dateStringToFuzzyDate * Add types * Don't retry 401s * Don't catch errors on constituent search or creation * Concatenate integrationErrors * Add throwHttpErrors * Set default for lookup_id to userId * Pass constituentId to updateConstituent * Remove try/catch * Use camelCase traits * Add filterObjectListByMatchFields * Check if primary property is defined * DOTORG-839 Added authentication test (#3) * Don't match on country * Use datetime type * Strip non-numeric characters from phone when matching * Don't match on undefined boolean fields * Update generated-types.ts * Fix linting errors * Move fixtures out of tests directory * Update constituentData * Update default lookup_id mapping * Update testAuthentication * Remove UNEXPECTED_RECORD_COUNT error * Update tests --------- Co-authored-by: twilio-hwong <[email protected]> * Google Analytics 4 Web Destination (#1012) * addPaymentInfo Action * ga4 types, properties, and functions * set config fields action poc * set config fields action poc * GA4 all action created * Remove unit test cases files * Added defaultSubscription tag in viewItemList and generateLead Action * added register code for GA4 in broweser-destinations * add customEvent action * set config action & custom event action * Delete snapshot.test.ts * Delete index.test.ts * clean up & add mappings for preset * updated types and removed picklist * Added test cases for GA4 actions * Added test cases * added custom event unit test + cleaned up merge issues and commented code * fixed typo * add back ripe and commandbar to index file * added comment on non using variable * Apply suggestions from code review Co-authored-by: Neek Sandhu <[email protected]> * revert set configuration field actions * added updateUser function, and updated event to payload * reverted back gtag function and datalayer setup * add gtag type and remove comment * update yarn.lock file * add viewItemList & disable linter for args * remove gtag.js type dependency * update unit tests * added events to defaultSubscriptions * update index.js --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ankit Gupta <[email protected]> Co-authored-by: Neek Sandhu <[email protected]> * livelike-cloud action destination (PE-41) (#1020) * created livelike-cloud action destination with one trackEvent action and three presets and added unit tests * Update packages/destination-actions/src/destinations/livelike-cloud/trackEvent/index.ts Co-authored-by: Joe Ayoub <[email protected]> --------- Co-authored-by: Joe Ayoub <[email protected]> * Qualtrics - Fixed timezone issue in unit test (#1026) * Fixed timezone issue in unit test * refactored to use dayjs from lib * generate types (#1028) * PE-47 - Merge Algolia Insights (#1027) * Algolia insights integration (#975) * feat: initial commit after scaffold * feat: clarify insights API and impliment as distinct actions * test: write test for conversion destination * test: write test for click and view destination * test: write auth schema test * create productClick presets * add presets to destination * create all event presets * remove default imports for actions * add testAuthentication method for algolia-insights --------- Co-authored-by: Beatrice Parfait <[email protected]> * fixing snapshots and replacing userId and anonId with userToken * fixing timestamps in tests --------- Co-authored-by: Wesley Walser <[email protected]> Co-authored-by: Beatrice Parfait <[email protected]> * VWO Cloud Mode Description changes (#1015) * Description changes and changes in utility * Tests altered for new format * Update CODEOWNERS (#1029) * [HEAP-38485] Move to the integrations endpoint (#1016) * [HEAP-32036] First trackEvent implementation (#8) * [HEAP-32037] Send identify and add user properties requests (#9) * [HEAP-32037] Add user properties and migrate anonymous users * Hash anonymous user ID * Use message ID as idempotency key * Throw if parameters are missing * [HEAP-32884] backport filtering event properties (#10) * [HEAP-32884] backport filtering event properties - flat properties from the request payload before sending them to heap * address comments: - remove the embeded object under the util.ts, move it to flattenObj - remove unnecessary tests on identifyUser - import and use the embeded object and flatten object in trackEvent and identifyUser test not part of comments: - rename the file from flattenObj to flat * PR comments * Update packages/destination-actions/src/destinations/heap/trackEvent/index.ts Co-authored-by: Marín Alcaraz <[email protected]> * Update packages/destination-actions/src/destinations/heap/trackEvent/index.ts Co-authored-by: Marín Alcaraz <[email protected]> * Update packages/destination-actions/src/destinations/heap/trackEvent/index.ts Co-authored-by: Marín Alcaraz <[email protected]> * Update packages/destination-actions/src/destinations/heap/trackEvent/index.ts Co-authored-by: Marín Alcaraz <[email protected]> * remove unused file * save changes * save * fix library * remove accidental file * update tests * remove session id * PR comments * fix the tests * add user properties if more that one identifier is present * Revert "add user properties if more that one identifier is present" This reverts commit bb4fb94684be54c933e9375ae1fc877e876fbbd1. --------- Co-authored-by: Gediminas Rapolavicius <[email protected]> Co-authored-by: Yiyang Li <[email protected]> Co-authored-by: Marín Alcaraz <[email protected]> Co-authored-by: murphpdx <[email protected]> * Launchpad Segment Integration (#1010) * Launchpad Segment Integration We are now adding the ability to send events from segment into Launchpad.pm - the mission control for Product teams at scale. We are adding the following: * trackEvent * groupIdentifyUser * identifyUser We have added unit tests and have tested this manually. It requires the following: * apiRegion - EU by default. We have added the US as means of future extensibility. * apiSecret - given by Launchpad.pm while onboarding. * sourceName - to be added. * updating snapshots * Changes implemented following call with Joe Track() [x] Explicitly indicate which fields are required or optional [x] Look for traits and if not context.traits [x] Need description for the Action [x] Make Timestamp field required [x] Make messageId required. It will always be there. [x] getEventProperties: This line looks incorrect: id: payload.event, [x] source mapping looks incorrect: source: integration?.name == 'Iterable' ? 'Iterable' : 'segment', Identify() [x] Description should be updated. [x] identify() calls are often fired when a trait is collected, or when a userId is collected. [x] Maybe use wording: “Creates or updates a user profile, and adds or updates trait values on the user profile…” [x] Refactor the perform() function group() [x] Group Key - Amend description to better explain that group key is a way to connect multiple organizations together [x] groupId field - Should be updated [x] Consider adding anonymousId as a field [x] Handle when there are no traits. * changes * tests passing, removed the check on user_id, anonymous_id since none are required * fixing the types as well * fixing test --------- Co-authored-by: joe-ayoub-segment <[email protected]> * [STRATCONN-1950] Init new destination `Pinterest Conversions API` (#1030) * Init new destination `Pinterest Conversions API` * Update index.ts * Update index.ts * Update index.ts --------- Co-authored-by: rvadera12 <[email protected]> * Try to only pass in NODE_OPTIONS for node18+ (#1032) * Try using conditional for scripts * Remove NODE_OPTIONS from else * Echo the nodeversion * Try setting the node major version and testing that * Use correct variable in condition * Try a different approach * Use bash instead * Try to fix script * Add other remaining scripts * Changing name of new Algolia Insights Integration (#1038) * Register new action destinations (#1036) * Register new action destinations: Launchpad, Livelike Cloud, Twilio Studio, BlackBaud Raisers Edge Nxt, Pinterest Conversions Api * Fix path * add action to pinterest conversions api * add action to pinterest conversions api * add description to pinterest action * Register algolia insights (Actions) --------- Co-authored-by: rvadera12 <[email protected]> * Publish - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] - @segment/[email protected] * Use correct defaultPath for messageId (#1041) * Google ads v11 to v12 (#1018) * gooogle conversion v12 upgrade * changes * bug fix for test cases * gooogle conversion v12 upgrade * changes * bug fix for test cases * flag name changes * flag name change in test cases * review changes * revert ga4-types file change * revert ga4-types file change * revert ga4-types file change --------- Co-authored-by: manoj kumar <[email protected]> * [STRATCONN-1779]Add datadog stats for google ads api version (#1046) * adds stats for api version * adds missing statscontext parameter to getCustomVariables * refactor params * Voucherify-Segment.io Integration using action-destinations (#970) * initial destination configuration * identify customer action * add trackEvent * Generate screenEvent and pageEvent * Change the structure of track, page and screen events. * Delete test folder for now * Change the type definition * Delete timestamp * create group event * removed created_at property * hit to localhost address * Add unit tests * Some fixes * Change the URLs in perform method * Update URLs in tests * Delete unused testing authentication fn * Add snapshots * Add ability to pass a custom URL * Set type to required in page and screen events * Delete snapshots * Replace api endpoint (with regions) with custom URL * if there's no userId then use the anonymousId * removed space * added type property to rest of events * changed name of property 'name' to 'event' * Update index.ts * Update generated-types.ts * Delete unnecessary test - 'should throw an error when the name is not provided using page event' * Delete the 'voucherify' prefix * Slightly change the descriptions * generated types * Separate URL functions into separate files Change the file names to be more descriptive. * Reduce the getVoucherifyEndpointURL function * delete * Update the descriptions - Also deleted the 'event' prop from screen/page events and now the 'name' in screen/page event is no longer required. * Commit the generated types * Reduce the number of events to three. Track Custom Event, Identify Customer, Add group to customer metadata * Add customer attributes to traits in upsertCustomer action * Update generated-types.ts * Add testAuthentication * Update names of actions in unit tests * add firstName and lastName * Add email to custom event processing * Delete email from upsertCustomer (leave it only in traits) * Add email to description * Add email to customer processing * Update testAuthentication * update addCustomEvent * Update packages/destination-actions/src/destinations/voucherify/upsertCustomer/index.ts Co-authored-by: Joe Ayoub <[email protected]> * Fix issue with mapping the user attributes and improve Presets * generate types * change email properties * generated types * custom url information * generated types * Update the desc of Custom URL * minor changes from last PR * Update index.ts --------- Co-authored-by: Patryk Smolarz <[email protected]> Co-authored-by: Patryk Smolarz <[email protected]> Co-authored-by: Joe Ayoub <[email protected]> * HGI 372 - Fix Segment Profiles Destination (#1047) * Added `All: false` in Tracking API event * Changed PAPI Token field from `string` to `password` * Fixed minor typos * HGI-368 | Fixed the missing x-signature in request header when batching is enabled (#1043) * worked on HGI-368 Fix * added a unit test case for same fix --------- Co-authored-by: Gaurav Kochar <[email protected]> * Mixpanel destination: use user-agent for browser data (#1035) * remove device manufacturer - use user-agent * userAgent is only sent on web * New SalesWings API urls (#1039) * Use new SalesWings API urls * Do not check response status in testAuthentication * Fix testAuthentication * Remove unused file * Mixpanel - identify null id fix (#1033) * fix engage for null user_id * use distinct_id with default for /engage * formatting fix * revert some more auto formatting * formatting * fix test * Remove distinct_id mapping and use null-coalescing * Descriptions changed for VWO Web Destination (#1006) * Descriptions changed * Revert Changes for cloud mode * Test altered for new format * fixing Mixpanel broken test (#1055) --------- Co-authored-by: Nick Aguilar <[email protected]> Co-authored-by: Stella Chung <[email protected]> Co-authored-by: Simon <[email protected]> Co-authored-by: A Murphy <[email protected]> Co-authored-by: kishoredevarasettyn <[email protected]> Co-authored-by: kishoredevarasettyn <[email protected]> Co-authored-by: Denis Egorushkin <98813888+denis…
austinpray-mixpanel
pushed a commit
that referenced
this pull request
Jun 26, 2024
* WIP: launchdarkly-audiences * wip - add some auth stuff * Updated launchdarkly segment integration * Cleaned up console log and added description to the action * tidy up * add syncAudience tests * add auth tests * update tests with url constants * Apply suggestions from code review Co-authored-by: Henry Barrow <[email protected]> * Fix snapshot tests and make a few small improvements (#5) * Improve snake case handling and fix broken tests * Update packages/destination-actions/src/destinations/launchdarkly-audiences/syncAudience/custom-audience-operations.ts Co-authored-by: Cliff Tawiah <[email protected]> --------- Co-authored-by: Cliff Tawiah <[email protected]> * Apply suggestions from code review add recommended service token roles Co-authored-by: Henry Barrow <[email protected]> * pr feedback: updating definitions & prod urls * remove outdated comment, add api version to extendRequest * docs feedback * additional docs feedback Co-authored-by: Molly <[email protected]> * Added context kind to segment audience payload * Fixed snapshot tests * Fixed snapshot test * set static apiKey for snapshots * Update default context_key * Add joe's updates (#8) --------- Co-authored-by: Clifford Tawiah <[email protected]> Co-authored-by: Henry Barrow <[email protected]> Co-authored-by: Cliff Tawiah <[email protected]> Co-authored-by: Molly <[email protected]>
austinpray-mixpanel
pushed a commit
that referenced
this pull request
Jun 26, 2024
* Update Wisepops loader URL * Update URLs * Fix lint * WIS-3633 Update Wisepops segment destination for new goal tracking (#5) * WIS-3633 Declare revenue in object if new goal * WIS-3633 Update generated types * WIS-3633 Remove default goal identifier (#6) * WIS-3633 Declare revenue in object if new goal * WIS-3633 Update generated types * WIS-3633 Remove default goal identifier --------- Co-authored-by: clementai <[email protected]> Co-authored-by: Clément Aigreault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues for Mixpanel Actions:
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.