Release/1.6.1 (#153)

* update pom after release

* Update README.md

* fix before deploy script

* Clean/pom and package (#118)

* Add UTF-8 encoding

* Rename package

* fix readme

* added coverage

* Excluded openjdk job if branch is master (#119)

* Excluded openjdk job if branch is master

* test on develop branch

* use matrix for build config

* test on develop branch

* Set back develop branch

* Update issue templates

Updated templates

* Feature/spot bugs (#126)

* Include spotbugs to build

* Fix bugs + parse when retrieving TAF AMD

* Feature/rmk (#110)

* Handle parsing of AO1 and AO2 tokens

* Parse remark Wind peak

Added english and french translations

* Handle parsing of Windshift in remarks

* Handle decoding of tower visibility

* Parse surface visibility in remarks

* Fix visibility regex

* Handle decoding of variable prevailing visibility

* Handle decoding of sector visibility

* Handle visibility at second location

* Handle tornadic activity in remark

* fix typo

* Use replaceFirst instead of replaceAll

* Fix coverage

* Handle parse of precipitation in remarks

Updated pregMatch method.

* Added test and translation for thunderstorm beg end

* Handle thunderstorm location

* Handle parse of hail size in remark

* Parse snow pellet intensity in remark

* Parse virga in remarks

* Handle parse of ceiling height in remark

* Parse obscurations in remarks

* fix tests

* Parse Variable sky condition in remarks

* Parse ceiling at second location in remarks

* Clean traduction keys

* Use Message attribute instead of calling static

* Added logging on unknown token in remark

* Add missing translation keys

* Add RemarkParser to AbstractPArser

Fix test

* fix conflicts

* remove virga from remarkParser since it is single token

* Feature/rmk sea level pressure (#123)

* Handle parse of sea level pressure in remark

* Handle SLPNO token

* fix tests

* Feature/rmk pressure rinsing falling rapidly (#124)

* Handle parse of sea level pressure in remark

* Handle SLPNO token

* Handle parse of pressure rising and falling rapidly

* Feature/rmk snow increasing rapidly (#125)

* Handle parse of sea level pressure in remark

* Handle SLPNO token

* fix tests

* Handle parse of pressure rising and falling rapidly

* Handle parse of snow incresing rapidly in remarks

* deactivate checkstyle

* remove cases of parse method

* set back checkstyle

* Include sonarCloud in build (#131)

* Include sonarCloud in build

* Added scripts for install and deploy

* fix travis yml

* remove sonar from cache

* Added url for sonar

* install script

* Fix addons

* added branchname for sonar

* update script

* disable codeclimate checkstyle

* remove codeclimate

* Update script.sh

* Update script.sh

* Add toString method in package model.trend.validity (#129)

* Add to string method for entities in model (#130)

* Add to string method for entities in model

* Add tests on toString method

Signed-off-by: jk KPADEY <[email protected]>

* Fix codacy + test

Signed-off-by: jk KPADEY <[email protected]>

* Update readme (#132)

* Feature/to string metar (#133)

* updated script to add PR sonar

Signed-off-by: jk KPADEY <[email protected]>

* Added toString to
- metar class
- Abstract trends class

Fix toString in
- AbstractWeatherContainer

Added asserts on metar toString

Signed-off-by: jk KPADEY <[email protected]>

* fix review

Signed-off-by: jk KPADEY <[email protected]>

* update pom after release

Signed-off-by: jk KPADEY <[email protected]>

* Update README.md

* fix deploy scripts

Signed-off-by: jk KPADEY <[email protected]>

* Fix messages (#135)

Use unicode for french accents

* Remove prefix rule in checkstyle (#136)

* Remove prefix rule in checkstyle
Rename fields
Added pojo-tester dependency for test scope
Added tests

Signed-off-by: jk KPADEY <[email protected]>

* Rename test method

* update model

* Added depth and enable quiet mode in git (#137)

* Bump pitest-maven from 1.4.0 to 1.4.7 (#138)

Bumps [pitest-maven](https://github.com/hcoles/pitest) from 1.4.0 to 1.4.7.
- [Release notes](https://github.com/hcoles/pitest/releases)
- [Commits](hcoles/pitest@pitest-parent-1.4.0...pitest-parent-1.4.7)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump maven-javadoc-plugin from 2.9.1 to 3.1.0 (#139)

Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 2.9.1 to 3.1.0.
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-2.9.1...maven-javadoc-plugin-3.1.0)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump maven-source-plugin from 3.0.0 to 3.0.1 (#140)

Bumps maven-source-plugin from 3.0.0 to 3.0.1.

Signed-off-by: dependabot[bot] <[email protected]>

* Bump nexus-staging-maven-plugin from 1.6.7 to 1.6.8 (#141)

Bumps nexus-staging-maven-plugin from 1.6.7 to 1.6.8.

Signed-off-by: dependabot[bot] <[email protected]>

* Bump opencsv from 4.1 to 4.5 (#143)

Bumps opencsv from 4.1 to 4.5.

Signed-off-by: dependabot[bot] <[email protected]>

* Bump jacoco-maven-plugin from 0.8.1 to 0.8.3 (#142)

Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.1 to 0.8.3.
- [Release notes](https://github.com/jacoco/jacoco/releases)
- [Commits](jacoco/jacoco@v0.8.1...v0.8.3)

Signed-off-by: dependabot[bot] <[email protected]>

* Added toString method in trends and TAF classes (#144)

* To string/i18n (#147)

* Added toString method + i18n

* Added tests

* Added translations

* Updated jacoco and pitest thresholds

* update airport list (#148)

* Bugfix/rmk slp (#149)

* Fix bug when parsing remark matching obscuration regex

* Fix checkstyle

* Fix codacy review

* Bump opencsv from 4.5 to 4.6 (#150)

Bumps opencsv from 4.5 to 4.6.

Signed-off-by: dependabot[bot] <[email protected]>

* Cleanup (#151)

* updated the license

* Clean up code
Added override annotations
Fixed regex
remove `continue` token

* Fixed the github release process

* Updated README

Added Jetbrains icons and link

* Added jetbrains icon

* Bump maven-compiler-plugin from 3.8.0 to 3.8.1 (#152)

Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.8.0 to 3.8.1.
- [Release notes](https://github.com/apache/maven-compiler-plugin/releases)
- [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.8.0...maven-compiler-plugin-3.8.1)

Signed-off-by: dependabot[bot] <[email protected]>

* Updated version in pom and README

* Extract variable
Created constant

* feature/TrunkBasedDevelopment: (#154)

- Updated travis file to remove build on develop branch
- Updated CONTRIBUTING.md to add guidelines for development
- Updated the pom version
- Updated the version in the readme

* fix Contributing.md file

* Fix script to filter branch

* Fix codacy remark

* Fix codacy remark

* Fix codacy remark

* Update pom to release 1.6.1 since 1.6.0 has already been released

.travis.yml

@@ -4,38 +4,37 @@ cache:
   directories:
     - '$HOME/.m2/repository'
     - '$HOME/.sonar/cache'
+
 addons:
   sonarcloud:
     organization: "mivek-github"
     token:
       secure: $SONARCLOUD_TOKEN
 
-jobs:
-  include:
-    - if: branch in (develop, master)
-      jdk: oraclejdk8
-    - if: branch = develop
-      jdk: openjdk8
+jdk: oraclejdk8
 
 before_install:
-  # Retrieve keys only if building branch is either develop or master and not a pull request
+  # Retrieve keys only if build is not on a pull request
   - bash scripts/before_install.sh
 
 install:
   - mvn compile test-compile
 
 script:
-  # If the branch is either develop or master then the deploy goal is used otherwise the maven install is used
+  # If the branch is master then the deploy goal is used otherwise the maven install is used
   - bash scripts/script.sh
 
-before_deploy: bash scripts/before_deploy.sh
+before_deploy:
+  - VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
+  - bash scripts/before_deploy.sh ${VERSION}
 
 deploy:
   provider: releases
-  file: target/metarParser-$version.jar
+  file: target/metarParser-${VERSION}.jar
   api_key:
     secure: $GITHUB_OATH
   skip_cleanup: true
   draft: true
+  name: ${VERSION}
   on:
     branch: master

CONTRIBUTING.md

@@ -6,14 +6,28 @@
 Open an issue describing the bug and the steps to reproduce it.
 If you are willing to fix the bug:
 
-* Open a Github Pull request 
-* Reference the issue in the pull request (Put the name/number of the issue inside a commit or inside the pull request description).
-* Make sure the PR passes checks (coverage, code climate, codacy...)
+*  Open a Github Pull request 
+*  Reference the issue in the pull request (Put the name/number of the issue inside a commit or inside the pull request description).
+*  Make sure the PR passes checks (coverage, sonar, codacy...)
 
 **Add a new feature**
 
 If you want to add a new feature, open an issue describing the feature you want to add.
 
+**Development flow**
+
+*   Create a branch from master. Prefix the branch name with the type of branch you want to create. Eg: "feature/", "bugfix/", "clean/"
+
+*   Update the pom
+    *   For a feature bump the minor version of the pom. Eg: 1.6.0 -> 1.7.0
+    *   For a bug or a clean bump the patch version of the pom. Eg: 1.6.0 -> 1.6.1
+
+*   Update the README with the new version of the project
+
+*   Add new code and the tests
+
+*   Push code and create the pull request towards the master branch
+
 **Internationalization**
 
 This project currently supports English and French languages. 

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2018 mivek
+Copyright (c) 2018-2019 mivek
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -1,16 +1,15 @@
-Master:
 [![Build Status](https://travis-ci.org/mivek/MetarParser.svg?branch=master)](https://travis-ci.org/mivek/MetarParser)
-Develop:
-[![Build Status](https://travis-ci.org/mivek/MetarParser.svg?branch=develop)](https://travis-ci.org/mivek/MetarParser)
 [![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=io.github.mivek%3AmetarParser&metric=alert_status)](https://sonarcloud.io/dashboard?id=io.github.mivek%3AmetarParser)
 [![Coverage](https://sonarcloud.io/api/project_badges/measure?project=io.github.mivek%3AmetarParser&metric=coverage)](https://sonarcloud.io/dashboard?id=io.github.mivek%3AmetarParser)
+
+![](jetbrains_small.png)
 # MetarParser
 
 
 This java lib provides a Metar and TAF decoder.
 
 Use the MetarFacade class and its method decode to decode a metar.
-Use the MetarFacade class and its method retrieveFromAirport to get the metar of an airport. This metod take the icao code as parameter.
+Use the MetarFacade class and its method retrieveFromAirport to get the metar of an airport. This method take the icao code as parameter.
 The trends of the metar are not parsed.
 
 ## Table of content
@@ -30,18 +29,18 @@ The trends of the metar are not parsed.
 <dependency>
   <groupId>io.github.mivek</groupId>
   <artifactId>metarParser</artifactId>
-  <version>1.4</version>
+  <version>1.6.1</version>
 </dependency>
 ```
-Or check [here](https://search.maven.org/artifact/io.github.mivek/metarParser/1.3/jar) if you are not using maven.
+Or check [here](https://search.maven.org/artifact/io.github.mivek/metarParser/) if you are not using maven.
 ## Model
 The model is generated by using the Eclipse visualization tool [ObjectAid](http://www.objectaid.com/home).
 When updating classes in packages io.github.mivek.enums or io.github.mivek.model, the class diagram is also updated.
 When added a new class/enumeration in one of those package, drag and drop the new class to model.ucls and generate a new jpeg of the class diagram.
 ![class diagram](model.jpg)
 ### Enumerations
 
-The application contains numerous enumarations to represent datas.
+The application contains numerous enumerations to represent data.
   - CloudType: to represent the type of cloud.
   - CloudQuantity: to represent the amount of clouds.
   - Intensity: to represent the intensity of a meteorological phenomenon.
@@ -170,9 +169,11 @@ TAF taf = facade.retrieveFromAirport(icao);
 English and french locales are supported by the library. The library uses the user's locale.
 The default locale is english.
 
-#### Change the locale
+#### Change the locale and contributing
 To change the locale use the method `setLocale(Locale)` of the class `Messages.java`
 ```(java)
 Messages.getInstance().setLocale(Locale.FRENCH); // Changes the locale to french.
 ```
-If you are willing to add a new locale please see [Contributing.md file](CONTRIBUTING.md).
+If you are willing to add a new locale or contribute to the project please see [Contributing.md file](CONTRIBUTING.md).
+
+[Jetbrains](https://www.jetbrains.com/?from=metarParser) open source project.

checkstyle.xml

@@ -1,10 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
 
-<!--
-    Checkstyle-Configuration: MetarParser
-    Description: 
-Checkstyle configuration that checks the sun coding conventions.
+<!--
+    Checkstyle-Configuration: MetarParser
+    Description: 
+Checkstyle configuration that checks the sun coding conventions.
 -->
 <module name="Checker">
   <property name="severity" value="warning"/>
@@ -17,9 +17,6 @@ Checkstyle configuration that checks the sun coding conventions.
     <module name="ConstantName"/>
     <module name="LocalFinalVariableName"/>
     <module name="LocalVariableName"/>
-    <module name="MemberName">
-      <property name="format" value="^f[A-Z][a-zA-Z0-9]*$"/>
-    </module>
     <module name="MethodName"/>
     <module name="PackageName"/>
     <module name="ParameterName">