-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Manage payloads #54
Feature - Manage payloads #54
Conversation
@jbaptperez reviewing and testing today. Apologies for delay. |
@jbaptperez How hard would it be also show all the payloads loaded in the Caldera, and then have just the local ones the user uploaded have the the ability to delete? *might be useful to show all the payloads (and their source plugins) in the table as well. Or we should make it clear on the payloads view, that it is ignoring all loaded payloads from plugins. |
Tested on Mac. All functionality works as described. |
@elegantmoose, I made the changes you asked for.
Technically, I had to use complete relative paths to payloads returned by the API (the GET new parameters I added in the previous caldera PR). |
This LGTM, just that one new comment I left above, and then the move the payloads under the Configuration menu. |
84deb7f
to
1295456
Compare
e71d726
to
81c90e1
Compare
@elegantmoose, done and rebased. I also fixed the upload modal width (insufficient when using files with long names) and, as I just discovered there were another existing upload modal in the adversaries view, I adapted the payload one for consistency. |
@jbaptperez Thank you. 👏 Great PR. |
This is the GUI part of the payload management, which depends on the Caldera PR #2989.
data/payloads
(and deletion),Navigation.vue
,